tests: disable telemetry during pytest via conftest; lock milestone saves

Author: dsarno

UnityMcpBridge/UnityMcpServer~/src/telemetry.py

@@ -192,9 +192,13 @@ def _load_persistent_data(self):
     def _save_milestones(self):
         """Save milestones to disk"""
         try:
-            self.config.milestones_file.write_text(json.dumps(self._milestones, indent=2))
-        except Exception as e:
-            logger.warning(f"Failed to save milestones: {e}")
+            with self._lock:
+                self.config.milestones_file.write_text(
+                    json.dumps(self._milestones, indent=2),
+                    encoding="utf-8",
+                )
+        except OSError as e:
+            logger.warning(f"Failed to save milestones: {e}", exc_info=True)
 
     def record_milestone(self, milestone: MilestoneType, data: Optional[Dict[str, Any]] = None) -> bool:
         """Record a milestone event, returns True if this is the first occurrence"""

tests/conftest.py

@@ -0,0 +1,8 @@
+import os
+
+# Ensure telemetry is disabled during test collection and execution to avoid
+# any background network or thread startup that could slow or block pytest.
+os.environ.setdefault("DISABLE_TELEMETRY", "true")
+os.environ.setdefault("UNITY_MCP_DISABLE_TELEMETRY", "true")
+os.environ.setdefault("MCP_DISABLE_TELEMETRY", "true")
+