You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GTK: Fix wxGUIEventLoop::DoYieldFor compatibility when using with CEF
DO NOT replace the global GDK event handler with our 'wxgtk_main_do_event'.
Because this trick rely on one uncertain assumption:
No one besides us, had done gdk_event_handler_set() already.
In most case, this might be true.
But a single exception can destroy this trick completely.
For example, when we want to embed CEF, Chromium will use a custom gdk_event_handler too.
This trick will render all CEF browser window/view no longer usable.
GTK3 should be blamed for not offering any gdk_event_handler_get() or similar stuff for a safe trick here.
In GTK4, there's a more sane way to get the job done.
So let's do it in a more conservative way.
If there're GdkEvents, we handle them via 'wxgtk_main_do_event',
all other events should be handle by one gtk_main_iteration().
I'm not sure whether this is really okay, but it seems a nicer and less intrusive way to do things.
0 commit comments