Random tests from backlog

Author: sebersole

hibernate-core/src/test/java/org/hibernate/orm/test/component/basic/ComponentTest.java

@@ -47,6 +47,13 @@ protected void applySettings(StandardServiceRegistryBuilder builder) {
 		builder.applySetting( Environment.GENERATE_STATISTICS, "true" );
 	}
 
+	@Test
+	void testJoining() {
+		sessionFactory().inTransaction( (session) -> {
+			session.createQuery( "select u from User u join u.person p" ).list();
+		} );
+	}
+
 	@Override
 	public MetadataImplementor produceModel(StandardServiceRegistry serviceRegistry) {
 		MetadataImplementor metadata = super.produceModel( serviceRegistry );

hibernate-core/src/test/java/org/hibernate/orm/test/idclass/IdClassCtorTests.java

@@ -0,0 +1,45 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.orm.test.idclass;
+
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+import jakarta.persistence.IdClass;
+import jakarta.persistence.Table;
+import org.hibernate.testing.orm.junit.DomainModel;
+import org.hibernate.testing.orm.junit.SessionFactory;
+import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.junit.jupiter.api.Test;
+
+/**
+ * @author Steve Ebersole
+ */
+@DomainModel(annotatedClasses = {IdClassCtorTests.SystemUser.class, IdClassCtorTests.SystemUserId.class})
+@SessionFactory
+public class IdClassCtorTests {
+	@Test
+	void testIdClassRecordUsage(SessionFactoryScope factoryScope) {
+		factoryScope.inTransaction( (session) -> {
+			session.find( SystemUser.class, new SystemUserId( "payroll", "admin" ) );
+			session.createQuery( "from SystemUser u where u.privileges % 2 = 0" ).list();
+		} );
+	}
+
+	@Entity(name="SystemUser")
+	@Table(name="SystemUser")
+	@IdClass( SystemUserId.class )
+	public static class SystemUser {
+		@Id
+		private String systemName;
+		@Id
+		private String userName;
+		@Column(name = "privs")
+		private int privileges;
+	}
+
+	public record SystemUserId(String systemName, String userName) {
+	}
+}

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/naturalid/XRefTests.java

@@ -5,8 +5,11 @@
 package org.hibernate.orm.test.mapping.naturalid;
 
 import jakarta.persistence.Entity;
+import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.Id;
+import jakarta.persistence.OptimisticLockException;
 import jakarta.persistence.Table;
+import org.hibernate.StaleObjectStateException;
 import org.hibernate.annotations.NaturalId;
 import org.hibernate.annotations.NaturalIdCache;
 import org.hibernate.cache.internal.NaturalIdCacheKey;
@@ -27,14 +30,20 @@
 import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
 import static org.hibernate.KeyType.NATURAL;
 
 /// Tests for [org.hibernate.engine.spi.NaturalIdResolutions]
 ///
 /// @author Steve Ebersole
 @SuppressWarnings("JUnitMalformedDeclaration")
 @ServiceRegistry(settings = @Setting( name = CacheSettings.USE_SECOND_LEVEL_CACHE, value = "true" ) )
-@DomainModel(annotatedClasses = {XRefTests.Book.class,XRefTests.Bookmark.class,XRefTests.Pen.class})
+@DomainModel(annotatedClasses = {
+		XRefTests.Another.class,
+		XRefTests.Book.class,
+		XRefTests.Bookmark.class,
+		XRefTests.Pen.class
+})
 @SessionFactory(useCollectingStatementInspector = true)
 public class XRefTests {
 	public static final String BOOK_ISBN = "123-4567-890";
@@ -198,6 +207,31 @@ private void verifyCacheResolution(Class<?> entityType, String naturalId, int id
 		assertThat( resolution.getValue() ).isEqualTo( id );
 	}
 
+	@Test
+	void testDeletionInOtherSession(SessionFactoryScope factoryScope) {
+		var created = factoryScope.fromTransaction( (session) -> {
+			var other = new Another( "something" );
+			session.persist( other );
+			return other;
+		} );
+
+		factoryScope.inTransaction( (session) -> {
+			var b = session.getReference( Another.class, created.id );
+			session.remove( b );
+		} );
+
+		created.name = "something else";
+		try {
+			factoryScope.inTransaction( (session) -> {
+				session.merge( created );
+			} );
+			fail( "Expecting OptimisticLockException / StaleObjectStateException" );
+		}
+		catch (OptimisticLockException expected) {
+			assertThat( expected.getCause() ).isInstanceOf( StaleObjectStateException.class );
+		}
+	}
+
 	@BeforeEach
 	void createTestData(SessionFactoryScope factoryScope) {
 		factoryScope.inTransaction( (session) -> {
@@ -273,4 +307,21 @@ public Pen(Integer id, String manufacturer, String sku) {
 			this.sku = sku;
 		}
 	}
+
+	@Entity(name="Another")
+	@Table(name="others")
+	public static class Another {
+		@Id
+		@GeneratedValue
+		private Integer id;
+		@NaturalId
+		private String name;
+
+		public Another() {
+		}
+
+		public Another(String name) {
+			this.name = name;
+		}
+	}
 }