Skip to content

Commit 0e9624a

Browse files
committed
Deduplicate test case processing
1 parent 6f5ecb4 commit 0e9624a

File tree

1 file changed

+12
-28
lines changed

1 file changed

+12
-28
lines changed

packages/crypto/tests/wycheproof_secp256k1.rs

Lines changed: 12 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@ fn ecdsa_secp256k1_sha256() {
9393
tested += 1;
9494
assert_eq!(tc.tc_id as usize, tested);
9595
// eprintln!("Test case ID: {}", tc.tc_id);
96+
let message = hex::decode(tc.msg).unwrap();
97+
let message_hash = hashers::sha256(&message);
98+
let der_signature = hex::decode(tc.sig).unwrap();
9699

97100
match tc.result.as_str() {
98101
"valid" | "acceptable" => {
99-
let message = hex::decode(tc.msg).unwrap();
100-
let message_hash = hashers::sha256(&message);
101-
let der_signature = hex::decode(tc.sig).unwrap();
102102
let signature = from_der(&der_signature).unwrap();
103103
let valid = secp256k1_verify(&message_hash, &signature, &public_key).unwrap();
104104
assert!(valid);
@@ -107,10 +107,6 @@ fn ecdsa_secp256k1_sha256() {
107107
}
108108
}
109109
"invalid" => {
110-
let message = hex::decode(tc.msg).unwrap();
111-
let message_hash = hashers::sha256(&message);
112-
let der_signature = hex::decode(tc.sig).unwrap();
113-
114110
if let Ok(signature) = from_der(&der_signature) {
115111
match secp256k1_verify(&message_hash, &signature, &public_key) {
116112
Ok(valid) => assert!(!valid),
@@ -145,12 +141,12 @@ fn ecdsa_secp256k1_sha512() {
145141
tested += 1;
146142
assert_eq!(tc.tc_id as usize, tested);
147143
// eprintln!("Test case ID: {}", tc.tc_id);
144+
let message = hex::decode(tc.msg).unwrap();
145+
let message_hash = hashers::sha512(&message);
146+
let der_signature = hex::decode(tc.sig).unwrap();
148147

149148
match tc.result.as_str() {
150149
"valid" | "acceptable" => {
151-
let message = hex::decode(tc.msg).unwrap();
152-
let message_hash = hashers::sha512(&message);
153-
let der_signature = hex::decode(tc.sig).unwrap();
154150
let signature = from_der(&der_signature).unwrap();
155151
let valid = secp256k1_verify(&message_hash, &signature, &public_key).unwrap();
156152
assert!(valid);
@@ -159,10 +155,6 @@ fn ecdsa_secp256k1_sha512() {
159155
}
160156
}
161157
"invalid" => {
162-
let message = hex::decode(tc.msg).unwrap();
163-
let message_hash = hashers::sha512(&message);
164-
let der_signature = hex::decode(tc.sig).unwrap();
165-
166158
if let Ok(signature) = from_der(&der_signature) {
167159
match secp256k1_verify(&message_hash, &signature, &public_key) {
168160
Ok(valid) => assert!(!valid),
@@ -197,12 +189,12 @@ fn ecdsa_secp256k1_sha3_256() {
197189
tested += 1;
198190
assert_eq!(tc.tc_id as usize, tested);
199191
// eprintln!("Test case ID: {}", tc.tc_id);
192+
let message = hex::decode(tc.msg).unwrap();
193+
let message_hash = hashers::sha3_256(&message);
194+
let der_signature = hex::decode(tc.sig).unwrap();
200195

201196
match tc.result.as_str() {
202197
"valid" | "acceptable" => {
203-
let message = hex::decode(tc.msg).unwrap();
204-
let message_hash = hashers::sha3_256(&message);
205-
let der_signature = hex::decode(tc.sig).unwrap();
206198
let signature = from_der(&der_signature).unwrap();
207199
let valid = secp256k1_verify(&message_hash, &signature, &public_key).unwrap();
208200
assert!(valid);
@@ -211,10 +203,6 @@ fn ecdsa_secp256k1_sha3_256() {
211203
}
212204
}
213205
"invalid" => {
214-
let message = hex::decode(tc.msg).unwrap();
215-
let message_hash = hashers::sha3_256(&message);
216-
let der_signature = hex::decode(tc.sig).unwrap();
217-
218206
if let Ok(signature) = from_der(&der_signature) {
219207
match secp256k1_verify(&message_hash, &signature, &public_key) {
220208
Ok(valid) => assert!(!valid),
@@ -249,12 +237,12 @@ fn ecdsa_secp256k1_sha3_512() {
249237
tested += 1;
250238
assert_eq!(tc.tc_id as usize, tested);
251239
// eprintln!("Test case ID: {}", tc.tc_id);
240+
let message = hex::decode(tc.msg).unwrap();
241+
let message_hash = hashers::sha3_512(&message);
242+
let der_signature = hex::decode(tc.sig).unwrap();
252243

253244
match tc.result.as_str() {
254245
"valid" | "acceptable" => {
255-
let message = hex::decode(tc.msg).unwrap();
256-
let message_hash = hashers::sha3_512(&message);
257-
let der_signature = hex::decode(tc.sig).unwrap();
258246
let signature = from_der(&der_signature).unwrap();
259247
let valid = secp256k1_verify(&message_hash, &signature, &public_key).unwrap();
260248
assert!(valid);
@@ -263,10 +251,6 @@ fn ecdsa_secp256k1_sha3_512() {
263251
}
264252
}
265253
"invalid" => {
266-
let message = hex::decode(tc.msg).unwrap();
267-
let message_hash = hashers::sha3_512(&message);
268-
let der_signature = hex::decode(tc.sig).unwrap();
269-
270254
if let Ok(signature) = from_der(&der_signature) {
271255
match secp256k1_verify(&message_hash, &signature, &public_key) {
272256
Ok(valid) => assert!(!valid),

0 commit comments

Comments
 (0)