Add comments

chipshort · chipshort · commit 532e6ca69522 · 2025-06-06T12:57:33.000+02:00
diff --git a/x/wasm/keeper/relay.go b/x/wasm/keeper/relay.go
@@ -40,14 +40,15 @@ func (k Keeper) OnOpenChannel(
 	gasLeft := k.runtimeGasForContract(ctx)
 	res, gasUsed, execErr := k.wasmVM.IBCChannelOpen(codeInfo.CodeHash, env, msg, prefixStore, cosmwasmAPI, querier, ctx.GasMeter(), gasLeft, costJSONDeserialization)
 	k.consumeRuntimeGas(ctx, gasUsed)
-
+	// check if contract panicked / VM failed
 	if execErr != nil {
 		return "", errorsmod.Wrap(types.ErrExecuteFailed, execErr.Error())
 	}
 	if res == nil {
 		// If this gets executed, that's a bug in wasmvm
 		return "", errorsmod.Wrap(types.ErrVMError, "internal wasmvm error")
 	}
+	// check contract result
 	if res.Err != "" {
 		return "", types.MarkErrorDeterministic(errorsmod.Wrap(types.ErrExecuteFailed, res.Err))
 	}

Original file line number	Diff line number	Diff line change
`@@ -40,14 +40,15 @@ func (k Keeper) OnOpenChannel(`
`40`	`40`	`gasLeft := k.runtimeGasForContract(ctx)`
`41`	`41`	`res, gasUsed, execErr := k.wasmVM.IBCChannelOpen(codeInfo.CodeHash, env, msg, prefixStore, cosmwasmAPI, querier, ctx.GasMeter(), gasLeft, costJSONDeserialization)`
`42`	`42`	`k.consumeRuntimeGas(ctx, gasUsed)`
`43`		`-`
	`43`	`+ // check if contract panicked / VM failed`
`44`	`44`	`if execErr != nil {`
`45`	`45`	`return "", errorsmod.Wrap(types.ErrExecuteFailed, execErr.Error())`
`46`	`46`	`}`
`47`	`47`	`if res == nil {`
`48`	`48`	`// If this gets executed, that's a bug in wasmvm`
`49`	`49`	`return "", errorsmod.Wrap(types.ErrVMError, "internal wasmvm error")`
`50`	`50`	`}`
	`51`	`+ // check contract result`
`51`	`52`	`if res.Err != "" {`
`52`	`53`	`return "", types.MarkErrorDeterministic(errorsmod.Wrap(types.ErrExecuteFailed, res.Err))`
`53`	`54`	`}`