Skip to content

Commit 85b7f38

Browse files
authored
refactor: using slices.Contains to simplify the code (#2153)
Signed-off-by: NinaLua <[email protected]>
1 parent df02087 commit 85b7f38

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

x/wasm/keeper/msg_server.go

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package keeper
22

33
import (
44
"context"
5+
"slices"
56

67
errorsmod "cosmossdk.io/errors"
78

@@ -361,7 +362,7 @@ func (m msgServer) AddCodeUploadParamsAddresses(goCtx context.Context, req *type
361362

362363
addresses := params.CodeUploadAccess.Addresses
363364
for _, newAddr := range req.Addresses {
364-
if !contains(addresses, newAddr) {
365+
if !slices.Contains(addresses, newAddr) {
365366
addresses = append(addresses, newAddr)
366367
}
367368
}
@@ -393,7 +394,7 @@ func (m msgServer) RemoveCodeUploadParamsAddresses(goCtx context.Context, req *t
393394
addresses := params.CodeUploadAccess.Addresses
394395
newAddresses := make([]string, 0)
395396
for _, addr := range addresses {
396-
if contains(req.Addresses, addr) {
397+
if slices.Contains(req.Addresses, addr) {
397398
continue
398399
}
399400
newAddresses = append(newAddresses, addr)
@@ -408,15 +409,6 @@ func (m msgServer) RemoveCodeUploadParamsAddresses(goCtx context.Context, req *t
408409
return &types.MsgRemoveCodeUploadParamsAddressesResponse{}, nil
409410
}
410411

411-
func contains[T comparable](src []T, o T) bool {
412-
for _, v := range src {
413-
if v == o {
414-
return true
415-
}
416-
}
417-
return false
418-
}
419-
420412
func (m msgServer) selectAuthorizationPolicy(ctx context.Context, actor string) types.AuthorizationPolicy {
421413
if actor == m.keeper.GetAuthority() {
422414
return newGovAuthorizationPolicy(m.keeper.propagateGovAuthorization)

0 commit comments

Comments
 (0)