Skip to content

Commit f1835a1

Browse files
authored
Add logging for query err before redacting (#1605)
* Add logging for query err before redacting * Fix comments
1 parent 086c052 commit f1835a1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

x/wasm/keeper/query_plugins.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ func (q QueryHandler) Query(request wasmvmtypes.QueryRequest, gasLimit uint64) (
7171
}
7272

7373
// Issue #759 - we don't return error string for worries of non-determinism
74+
moduleLogger(q.Ctx).Debug("Redacting submessage error", "cause", err)
7475
return nil, redactError(err)
7576
}
7677

x/wasm/keeper/query_plugins_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
wasmvmtypes "github.com/CosmWasm/wasmvm/types"
1212
dbm "github.com/cometbft/cometbft-db"
13+
"github.com/cometbft/cometbft/libs/log"
1314
"github.com/cometbft/cometbft/libs/rand"
1415
tmproto "github.com/cometbft/cometbft/proto/tendermint/types"
1516
"github.com/cosmos/gogoproto/proto"
@@ -688,7 +689,7 @@ func TestQueryErrors(t *testing.T) {
688689
mock := keeper.WasmVMQueryHandlerFn(func(ctx sdk.Context, caller sdk.AccAddress, request wasmvmtypes.QueryRequest) ([]byte, error) {
689690
return nil, spec.src
690691
})
691-
ctx := sdk.Context{}.WithGasMeter(sdk.NewInfiniteGasMeter()).WithMultiStore(store.NewCommitMultiStore(dbm.NewMemDB()))
692+
ctx := sdk.Context{}.WithGasMeter(sdk.NewInfiniteGasMeter()).WithMultiStore(store.NewCommitMultiStore(dbm.NewMemDB())).WithLogger(log.TestingLogger())
692693
q := keeper.NewQueryHandler(ctx, mock, sdk.AccAddress{}, keeper.NewDefaultWasmGasRegister())
693694
_, gotErr := q.Query(wasmvmtypes.QueryRequest{}, 1)
694695
assert.Equal(t, spec.expErr, gotErr)

0 commit comments

Comments
 (0)