Linter PR 4: Checksum Validation #648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for better clarity and maintainability; enable all revive rules in golangci-lint configuration
|
What should checksums be like and how should they be validated? |
|
By convention the checksums are sha256 hashes of the .wasm blob, i.e. 32 bytes in binary or 64 lower case hex in string representation |
|
thank you! Do you think other types should be supported or anything like that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation of checksums to wasmvm.
It should only be reviewed after:
-- #589 should now be working fine, and actually has some similarish stuff inside it. You should check it for that I think, please. And if you have any requests for how #589 is contstructed, that's totally fine.