Skip to content

Run modernizer on codebase #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Run modernizer on codebase #657

merged 1 commit into from
Apr 23, 2025

Conversation

webmaster128
Copy link
Member

Just the result of

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -test -fix ./...

@webmaster128 webmaster128 requested a review from chipshort April 22, 2025 19:30
@faddat
Copy link
Contributor

faddat commented Apr 22, 2025

This will help, it was a step on the way to #589.

chipshort
chipshort approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipshort chipshort merged commit e4b4bd2 into main Apr 23, 2025
15 checks passed
@chipshort chipshort deleted the modernize branch April 23, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@chipshort chipshort chipshort approved these changes

@faddat faddat faddat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webmaster128 @faddat @chipshort