feat: remove Visual Studio Dark+ theme

Author: CosmicHorrorDev

README.md

@@ -86,7 +86,7 @@ For reference here are the sizes associated with their different functions
 | ^^ (fancy) | 937 | ^^ |
 | [`syntax::extra_no_newlines()`](https://docs.rs/two-face/latest/two_face/syntax/fn.extra_no_newlines.html) (onig) | 959 | 359 |
 | ^^ (fancy) | 935 | ^^ |
-| [`theme::extra()`](https://docs.rs/two-face/latest/two_face/theme/index.html) | 62 | 5 |
+| [`theme::extra()`](https://docs.rs/two-face/latest/two_face/theme/index.html) | 61 | 5 |
 
 In short the syntax definitions are the real chonky part, and if you're
 switching from `syntect` to `two-face`, then you can expect a ~0.5MiB increase
@@ -151,7 +151,6 @@ only make sense situationally, so you'll likely want to only expose a subset
 | O | One Half (light/dark) |
 | S | Solarized (light/dark)†, Sublime Snazzy |
 | T | TwoDark |
-| V | Visual Studio Dark+ |
 | Z | Zenburn |
 
 ## Legal

generated/themes.bin

@@ -82,7 +82,7 @@
 //! | ^^ (fancy) | 937 | ^^ |
 //! | [`syntax::extra_no_newlines()`] (onig) | 959 | 359 |
 //! | ^^ (fancy) | 935 | ^^ |
-//! | [`theme::extra()`] | 62 | 5 |
+//! | [`theme::extra()`] | 61 | 5 |
 //!
 //! In short the syntax definitions are the real chonky part, and if you're
 //! switching from `syntect` to `two-face`, then you can expect a ~0.5MiB increase
@@ -147,7 +147,6 @@
 //! | O | One Half (light/dark) |
 //! | S | Solarized (light/dark)†, Sublime Snazzy |
 //! | T | TwoDark |
-//! | V | Visual Studio Dark+ |
 //! | Z | Zenburn |
 //!
 //! ## Legal

src/lib.rs

@@ -485,12 +485,7 @@ mod tests {
             let _ = theme_set.get(theme_name);
         }
 
-        // ignoring `Visual Studio Dark+` as it will be removed later
-        const NUM_IGNORED: usize = 1;
-        assert_eq!(
-            theme_set.0.themes.len() - NUM_IGNORED,
-            EmbeddedThemeName::iter().len()
-        );
+        assert_eq!(theme_set.0.themes.len(), EmbeddedThemeName::iter().len());
         assert_eq!(
             EmbeddedLazyThemeSet::theme_names().len(),
             EmbeddedThemeName::iter().len()

src/theme/mod.rs

@@ -36,15 +36,15 @@ fn embedded_asset_sizes() {
 
     insta::assert_snapshot!(
         table,
-        @r"
+        @"
     | function | `two-face` (KiB) | `syntect` (KiB) |
     | ---: | ---: | ---: |
     | [`acknowledgement::listing()`] | 11 | - |
     | [`syntax::extra_newlines()`] (onig) | 961 | 360 |
     | ^^ (fancy) | 937 | ^^ |
     | [`syntax::extra_no_newlines()`] (onig) | 959 | 359 |
     | ^^ (fancy) | 935 | ^^ |
-    | [`theme::extra()`] | 62 | 5 |
+    | [`theme::extra()`] | 61 | 5 |
     "
     );
 }

tests/docs_watchdog/readme.rs

@@ -149,6 +149,11 @@ impl AssetsDir {
         let mut full_set = ThemeSet::load_defaults();
         full_set.themes.append(&mut theme_set.themes);
 
+        // TODO(cosmic): remove vs-dark+ here until it's gone upstream too
+        if full_set.themes.remove("Visual Studio Dark+").is_none() {
+            log::warn!("visual studio dark+ not found. this code can be removed now");
+        }
+
         let lazy_theme_set = LazyThemeSet::from(&full_set);
         Ok(lazy_theme_set)
     }