Skip to content

Commit 448f38e

Browse files
committed
remove unused parameter
1 parent e03e5ff commit 448f38e

File tree

2 files changed

+4
-20
lines changed

2 files changed

+4
-20
lines changed

cosmotech/coal/azure/adx/runner.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ def construct_create_query(files_data: Dict[str, Dict[str, Any]]) -> Dict[str, s
8383

8484
def insert_csv_files(
8585
files_data: Dict[str, Dict[str, Any]],
86-
kusto_client: KustoClient,
8786
ingest_client: QueuedIngestClient,
8887
runner_id: str,
8988
database: str,
@@ -214,10 +213,5 @@ def send_runner_data(
214213
LOGGER.error(T("coal.services.adx.exceptions").format(exceptions=r.get_exceptions()))
215214
raise RuntimeError(f"Failed to create table {k}")
216215
insert_csv_files(
217-
files_data=csv_data,
218-
kusto_client=kusto_client,
219-
ingest_client=ingest_client,
220-
runner_id=runner_id,
221-
database=database_name,
222-
wait=wait,
216+
files_data=csv_data, ingest_client=ingest_client, runner_id=runner_id, database=database_name, wait=wait
223217
)

tests/unit/coal/test_azure/test_adx/test_adx_runner.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def test_insert_csv_files(self, mock_file_descriptor_class, mock_csv_files):
144144
mock_ingest_client.ingest_from_file.side_effect = [mock_ingestion_result1, mock_ingestion_result2]
145145

146146
# Act
147-
insert_csv_files(files_data, mock_kusto_client, mock_ingest_client, runner_id, database, wait=False)
147+
insert_csv_files(files_data, mock_ingest_client, runner_id, database, wait=False)
148148

149149
# Assert
150150
# Verify that ingest_from_file was called for each CSV file
@@ -182,7 +182,7 @@ def test_insert_csv_files_with_wait(self, mock_file_descriptor_class, mock_check
182182
]
183183

184184
# Act
185-
insert_csv_files(files_data, mock_kusto_client, mock_ingest_client, runner_id, database, wait=True)
185+
insert_csv_files(files_data, mock_ingest_client, runner_id, database, wait=True)
186186

187187
# Assert
188188
# Verify that check_ingestion_status was called
@@ -223,16 +223,7 @@ def test_insert_csv_files_with_wait_max_retries(
223223
]
224224

225225
# Act
226-
insert_csv_files(
227-
files_data,
228-
mock_kusto_client,
229-
mock_ingest_client,
230-
runner_id,
231-
database,
232-
wait=True,
233-
wait_limit=2,
234-
wait_duration=0,
235-
)
226+
insert_csv_files(files_data, mock_ingest_client, runner_id, database, wait=True, wait_limit=2, wait_duration=0)
236227

237228
# Assert
238229
# Verify that check_ingestion_status was called
@@ -319,7 +310,6 @@ def test_send_runner_data(
319310
# Verify that insert_csv_files was called
320311
mock_insert_csv_files.assert_called_once_with(
321312
files_data=mock_csv_content,
322-
kusto_client=mock_kusto_client,
323313
ingest_client=mock_ingest_client,
324314
runner_id=runner_id,
325315
database=database_name,

0 commit comments

Comments
 (0)