test: [PROD-14393] check state of form in dataset creation dialog

Author: csm-thu

cypress/e2e/brewery/DatasetManager.cy.js

@@ -44,6 +44,7 @@ describe('Dataset manager can be empty on start', () => {
 describe('Data edition in dataset manager', () => {
   before(() => {
     stub.start();
+    stub.setOrganizations([ORGANIZATION_WITH_DEFAULT_ROLE_USER]);
     stub.setWorkspaces(WORKSPACES);
     stub.setSolutions([SOLUTION_WITH_TRANSLATED_RUN_TEMPLATES]);
     // we use the copy of DATASETS array to be able to reuse the same fixture
@@ -116,6 +117,48 @@ describe('Data edition in dataset manager', () => {
     DatasetManager.getDatasetMetadataDescription().should('contain', newDescription);
     DatasetManager.getDatasetMetadataTag(1).should('contain', newTag);
   });
+
+  it('correctly handles the form state even after closing and reopening the dataset creation dialog', () => {
+    DatasetManager.ignoreDatasetTwingraphQueries();
+    DatasetManager.switchToDatasetManagerView();
+
+    const stepsToCheckTwice = () => {
+      DatasetManager.startDatasetCreation();
+      DatasetManager.setNewDatasetName('canceledDataset');
+      DatasetManager.getDatasetCreationNextStep().click();
+      DatasetManager.selectNewDatasetSourceType('partially_prefilled_datasource');
+      DatasetManager.getConfirmDatasetCreation().should('be.disabled');
+      cy.get('[data-cy=text-input-etl_string_parameter]').type('{selectAll}{backspace}' + 'foo');
+      DatasetManager.getConfirmDatasetCreation().should('not.be.disabled');
+
+      DatasetManager.getNewDatasetSourceTypeSelect().click();
+      DatasetManager.getNewDatasetSourceTypeOptionFile().click();
+      DatasetManager.getConfirmDatasetCreation().should('be.disabled');
+
+      DatasetManager.selectNewDatasetSourceType('partially_prefilled_datasource');
+      DatasetManager.getConfirmDatasetCreation().should('not.be.disabled');
+
+      DatasetManager.getCancelDatasetCreation().click();
+      DatasetManager.getDatasetCreationDialog().should('not.exist');
+    };
+
+    stepsToCheckTwice();
+    stepsToCheckTwice();
+  });
+
+  it('correctly handles the form state even after closing and reopening the sub-dataset creation dialog', () => {
+    DatasetManager.ignoreDatasetTwingraphQueries();
+    DatasetManager.switchToDatasetManagerView();
+
+    const stepsToCheckTwice = () => {
+      DatasetManager.startSubdatasetCreation();
+      DatasetManager.getDatasetCreationNextStep().should('not.be.disabled');
+      DatasetManager.getCancelDatasetCreation().click();
+    };
+
+    stepsToCheckTwice();
+    stepsToCheckTwice();
+  });
 });
 
 describe('Dataset creation', () => {
@@ -296,7 +339,7 @@ describe('Refresh dataset', () => {
   after(stub.stop);
 
   it(
-    'can refresh ADT and AzureStorage datasets and display en empty dataset placeholder ' +
+    'can refresh ADT and AzureStorage datasets and display an empty dataset placeholder ' +
       'for the one created from scratch',
     () => {
       const refreshSuccessOptions = {

cypress/fixtures/stubbing/DatasetManager/solutions.js

@@ -17,20 +17,25 @@ export const SOLUTION = {
     {
       id: 'etl_enum_parameter',
       varType: 'enum',
-      enumValues: [
-        { key: 'option1', value: 'Option 1' },
-        { key: 'option2', value: 'Option 2' },
-      ],
+      options: {
+        enumValues: [
+          { key: 'option1', value: 'Option 1' },
+          { key: 'option2', value: 'Option 2' },
+        ],
+      },
     },
     {
       id: 'etl_list_parameter',
       varType: 'list',
-      enumValues: [
-        { key: 'option1', value: 'Option 1' },
-        { key: 'option2', value: 'Option 2' },
-      ],
+      options: {
+        enumValues: [
+          { key: 'option1', value: 'Option 1' },
+          { key: 'option2', value: 'Option 2' },
+        ],
+      },
     },
     { id: 'etl_string_parameter', varType: 'string' },
+    { id: 'etl_string_parameter_with_default_value', varType: 'string', defaultValue: 'is prefilled' },
     { id: 'etl_date_parameter', varType: 'date' },
   ],
   parameterGroups: [
@@ -39,6 +44,7 @@ export const SOLUTION = {
     { id: 'listGroup', parameters: ['etl_list_parameter'] },
     { id: 'stringGroup', parameters: ['etl_string_parameter'] },
     { id: 'dateGroup', parameters: ['etl_date_parameter'] },
+    { id: 'partiallyPrefilledGroup', parameters: ['etl_string_parameter', 'etl_string_parameter_with_default_value'] },
   ],
   runTemplates: [...DEFAULT_SOLUTION.runTemplates, ...CUSTOM_SUBDATASOURCES],
 };
@@ -70,14 +76,15 @@ export const SOLUTION_WITH_DYNAMIC_VALUES = {
 };
 
 export const SOLUTION_WITH_TRANSLATED_RUN_TEMPLATES = {
-  ...DEFAULT_SOLUTION,
+  ...SOLUTION,
   runTemplates: [
     ...DEFAULT_SOLUTION.runTemplates,
     {
       id: 'etl_run_template',
       labels: { en: 'ETL run template with dynamic filter', fr: 'Run template avec un filtre dynamique' },
       tags: ['datasource'],
     },
+    { id: 'partially_prefilled_datasource', parameterGroups: ['partiallyPrefilledGroup'], tags: ['datasource'] },
     {
       id: 'subdataset_run_template',
       labels: {