Revert "fix: [PROD-11887] fix wrong dirty state after clearing errors"

This reverts commit 1be17ae.

Author: nborde-CSM

src/components/ScenarioParameters/components/ScenarioParametersInputs/GenericTable.js

@@ -116,15 +116,11 @@ export const GenericTable = ({
 
   // Store last parameter in a ref
   // Update a state is async, so, in case of multiple call of updateParameterValue in same function
-  // parameter state value will be updated only in last call.
+  // parameter state value will be update only in last call.
   // We need here to use a ref value for be sure to have the good value.
   const lastNewParameterValue = useRef(parameter);
-  const dirtyState = useRef(false);
-
   const updateParameterValue = useCallback(
     (newValuePart, shouldReset = false) => {
-      const lastIsDirty = dirtyState.current;
-      dirtyState.current = isDirty;
       const newParameterValue = {
         ...lastNewParameterValue.current,
         ...newValuePart,
@@ -142,14 +138,14 @@ export const GenericTable = ({
         // Prevent useless update of parameterValue if multiple updateParameterValue was done before
         if (lastNewParameterValue.current === newParameterValue) {
           if (shouldReset) {
-            resetParameterValue(newParameterValue, lastIsDirty === isDirty);
+            resetParameterValue(newParameterValue);
           } else {
             setParameterValue(newParameterValue);
           }
         }
       });
     },
-    [resetParameterValue, setParameterValue, isDirty]
+    [resetParameterValue, setParameterValue]
   );
 
   const updateParameterValueWithReset = (newValuePart) => {
@@ -443,12 +439,9 @@ export const GenericTable = ({
   const onCellChange = updateOnFirstEdition;
 
   const onClearErrors = () => {
-    updateParameterValue(
-      {
-        errors: null,
-      },
-      true
-    );
+    updateParameterValue({
+      errors: null,
+    });
   };
 
   const buildErrorsPanelTitle = (errorsCount, maxErrorsCount) => {

src/components/ScenarioParameters/components/ScenarioParametersTabs/ScenarioParameterInput.js

@@ -49,9 +49,9 @@ const ScenarioParameterInput = ({ parameterData, context }) => {
           }
         };
 
-        const resetParameterValue = (newDefaultValue, keepDirty = false) => {
+        const resetParameterValue = (newDefaultValue) => {
           if (scenarioIdOnMount.current === getCurrentScenarioId()) {
-            resetField(parameterData.id, { defaultValue: newDefaultValue, keepDirty });
+            resetField(parameterData.id, { defaultValue: newDefaultValue });
           }
         };