Commit 1839f21
committed
Replace exception-based handling with logging for stopping already finished runs
- Updated `RunnerApiServiceImpl` to log a debug message instead of throwing an `IllegalStateException` when attempting to stop a finished run.
- Adjusted corresponding integration tests to validate the updated behavior using `assertDoesNotThrow`.1 parent 59bacd3 commit 1839f21
File tree
2 files changed
+12
-15
lines changed- runner/src
- integrationTest/kotlin/com/cosmotech/runner/service
- main/kotlin/com/cosmotech/runner/service
2 files changed
+12
-15
lines changedLines changed: 6 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| |||
1516 | 1515 | | |
1517 | 1516 | | |
1518 | 1517 | | |
1519 | | - | |
1520 | | - | |
1521 | | - | |
1522 | | - | |
1523 | | - | |
1524 | | - | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
1525 | 1521 | | |
1526 | 1522 | | |
1527 | 1523 | | |
| |||
1543 | 1539 | | |
1544 | 1540 | | |
1545 | 1541 | | |
1546 | | - | |
1547 | | - | |
1548 | | - | |
1549 | | - | |
1550 | | - | |
1551 | | - | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
1552 | 1545 | | |
1553 | 1546 | | |
1554 | 1547 | | |
| |||
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
37 | 41 | | |
38 | 42 | | |
39 | 43 | | |
| |||
141 | 145 | | |
142 | 146 | | |
143 | 147 | | |
144 | | - | |
145 | | - | |
| 148 | + | |
| 149 | + | |
146 | 150 | | |
147 | 151 | | |
148 | 152 | | |
| |||
0 commit comments