check dataset id list format

Author: vcarluer

scenariorun/src/main/kotlin/com/cosmotech/scenariorun/dataset/DatasetUtils.kt

@@ -3,6 +3,7 @@
 package com.cosmotech.scenariorun.dataset
 
 import com.cosmotech.api.config.CsmPlatformProperties
+import com.cosmotech.api.exceptions.CsmClientException
 import com.cosmotech.connector.api.ConnectorApiService
 import com.cosmotech.connector.domain.Connector
 import com.cosmotech.dataset.api.DatasetApiService
@@ -84,6 +85,9 @@ private fun addParameterValue(
 
 internal fun getDatasetIdListFromValue(paramValue: String): List<String> {
   if (paramValue.startsWith("[")) {
+    if (!(paramValue.last().equals(']'))) {
+      throw CsmClientException("Malformed dataset id list: must start with [ and end with ]")
+    }
     val datasetIds = paramValue.substring(1, paramValue.length - 1)
     return datasetIds.split(",")
   } else {

scenariorun/src/test/kotlin/com/cosmotech/scenariorun/ContainerFactoryTests.kt

@@ -11,6 +11,7 @@ import com.cosmotech.api.config.CsmPlatformProperties.CsmPlatformAzure.CsmPlatfo
 import com.cosmotech.api.config.CsmPlatformProperties.CsmPlatformAzure.CsmPlatformAzureEventBus.Authentication.SharedAccessPolicyDetails
 import com.cosmotech.api.config.CsmPlatformProperties.CsmPlatformAzure.CsmPlatformAzureEventBus.Authentication.Strategy.SHARED_ACCESS_POLICY
 import com.cosmotech.api.config.CsmPlatformProperties.CsmPlatformAzure.CsmPlatformAzureEventBus.Authentication.Strategy.TENANT_CLIENT_CREDENTIALS
+import com.cosmotech.api.exceptions.CsmClientException
 import com.cosmotech.connector.api.ConnectorApiService
 import com.cosmotech.connector.domain.Connector
 import com.cosmotech.connector.domain.Connector.IoTypes
@@ -1468,6 +1469,19 @@ class ContainerFactoryTests {
     parametersDatasetEnvTest(getScenarioTwoDatasetIds(), "3", "param3")
   }
 
+  @Test
+  fun `Build all containers for a Scenario DATASETID malformed list`() {
+    val scenario = getScenarioMalformedDatasetIds()
+    val datasets = listOf(getDataset(), getDataset2(), getDataset3())
+    val connectors = listOf(getConnector(), getConnector2(), getConnector3())
+    val workspace = getWorkspace()
+    val solution = getSolutionDatasetIds()
+    assertThrows(CsmClientException::class.java) {
+      factory.buildContainersPipeline(
+          scenario, datasets, connectors, workspace, getOrganization(), solution, CSM_SIMULATION_ID)
+    }
+  }
+
   @Test
   fun `Full get Start Info csmSimulationId`() {
     val startInfo = getStartInfoFromIds()
@@ -2603,6 +2617,37 @@ class ContainerFactoryTests {
             ))
   }
 
+  private fun getScenarioMalformedDatasetIds(): Scenario {
+    return Scenario(
+        id = "AQWXSZ",
+        name = "Test Scenario",
+        runTemplateId = "testruntemplate",
+        datasetList = listOf("1"),
+        parametersValues =
+            listOf(
+                ScenarioRunTemplateParameterValue(
+                    parameterId = "param1",
+                    value = "valParam1",
+                ),
+                ScenarioRunTemplateParameterValue(
+                    parameterId = "param2",
+                    value = "[",
+                ),
+                ScenarioRunTemplateParameterValue(
+                    parameterId = "param3",
+                    value = "2",
+                ),
+                ScenarioRunTemplateParameterValue(
+                    parameterId = "param4",
+                    value = "3",
+                ),
+                ScenarioRunTemplateParameterValue(
+                    parameterId = "param5",
+                    value = "999",
+                ),
+            ))
+  }
+
   private fun getScenarioTwoDatasetsAndDatasetIds(): Scenario {
     return Scenario(
         id = "AQWXSZ",