Check types for workspace file upload

Author: vcarluer

build.gradle.kts

@@ -39,7 +39,7 @@ group = "com.cosmotech"
 version = scmVersion.version
 
 val kotlinJvmTarget = 17
-val cosmotechApiCommonVersion = "0.1.22-SNAPSHOT"
+val cosmotechApiCommonVersion = "0.1.23-SNAPSHOT"
 val cosmotechApiAzureVersion = "0.1.6-SNAPSHOT"
 val azureSpringBootBomVersion = "3.14.0"
 
@@ -49,6 +49,7 @@ allprojects {
   apply(plugin = "io.gitlab.arturbosch.detekt")
 
   repositories {
+    mavenLocal()
     maven {
       name = "GitHubPackages"
       url = uri("https://maven.pkg.github.com/Cosmo-Tech/cosmotech-api-common")

workspace/src/main/kotlin/com/cosmotech/workspace/azure/WorkspaceServiceImpl.kt

@@ -33,6 +33,7 @@ import com.cosmotech.api.rbac.getCommonRolesDefinition
 import com.cosmotech.api.rbac.getPermissions
 import com.cosmotech.api.rbac.model.RbacAccessControl
 import com.cosmotech.api.rbac.model.RbacSecurity
+import com.cosmotech.api.utils.ResourceScanner
 import com.cosmotech.api.utils.compareToAndMutateIfNeeded
 import com.cosmotech.api.utils.getCurrentAuthenticatedMail
 import com.cosmotech.api.utils.getCurrentAuthenticatedUserName
@@ -69,7 +70,8 @@ internal class WorkspaceServiceImpl(
     private val solutionService: SolutionApiService,
     private val azureStorageBlobServiceClient: BlobServiceClient,
     private val azureStorageBlobBatchClient: BlobBatchClient,
-    private val csmRbac: CsmRbac
+    private val csmRbac: CsmRbac,
+    private val resourceScanner: ResourceScanner,
 ) : CsmAzureService(), WorkspaceApiService {
 
   override fun findAllWorkspaces(organizationId: String): List<Workspace> {
@@ -255,6 +257,7 @@ internal class WorkspaceServiceImpl(
         file.filename,
         destination)
 
+    resourceScanner.scanMimeTypes(file, csmPlatformProperties.upload.authorizedMimeTypes.workspaces)
     val fileRelativeDestinationBuilder = StringBuilder()
     if (destination.isNullOrBlank()) {
       fileRelativeDestinationBuilder.append(file.filename)

workspace/src/test/kotlin/com/cosmotech/workspace/azure/WorkspaceServiceImplTests.kt

@@ -10,6 +10,7 @@ import com.cosmotech.api.azure.sanitizeForAzureStorage
 import com.cosmotech.api.config.CsmPlatformProperties
 import com.cosmotech.api.exceptions.CsmResourceNotFoundException
 import com.cosmotech.api.rbac.CsmRbac
+import com.cosmotech.api.utils.ResourceScanner
 import com.cosmotech.api.utils.getCurrentAuthenticatedMail
 import com.cosmotech.organization.api.OrganizationApiService
 import com.cosmotech.solution.api.SolutionApiService
@@ -44,6 +45,7 @@ class WorkspaceServiceImplTests {
   @MockK private lateinit var azureStorageBlobBatchClient: BlobBatchClient
 
   @RelaxedMockK private lateinit var csmRbac: CsmRbac
+  @RelaxedMockK private lateinit var resourceScanner: ResourceScanner
 
   @Suppress("unused") @MockK private lateinit var cosmosTemplate: CosmosTemplate
 
@@ -59,10 +61,30 @@ class WorkspaceServiceImplTests {
                 solutionService,
                 azureStorageBlobServiceClient,
                 azureStorageBlobBatchClient,
-                csmRbac))
+                csmRbac,
+                resourceScanner,
+            ))
     mockkStatic(::getCurrentAuthenticatedMail)
     every { getCurrentAuthenticatedMail(csmPlatformProperties) } returns "[email protected]"
 
+    val csmPlatformPropertiesUpload = mockk<CsmPlatformProperties.Upload>()
+    val csmPlatformPropertiesAuthorizedMimeTypes =
+        mockk<CsmPlatformProperties.Upload.AuthorizedMimeTypes>()
+    every { csmPlatformPropertiesAuthorizedMimeTypes.workspaces } returns
+        listOf(
+            "application/zip",
+            "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet",
+            "application/x-tika-ooxml",
+            "text/csv",
+            "text/plain",
+            "text/x-yaml",
+        )
+    every { csmPlatformPropertiesUpload.authorizedMimeTypes } returns
+        csmPlatformPropertiesAuthorizedMimeTypes
+    every { csmPlatformProperties.upload } returns csmPlatformPropertiesUpload
+
+    every { workspaceServiceImpl getProperty "csmPlatformProperties" } returns csmPlatformProperties
+
     MockKAnnotations.init(this, relaxUnitFun = true)
     this.csmRbac = mockk<CsmRbac>(relaxed = true)
   }