feat: add main dataset sharing on runner or scenario sharing

Author: Leopold-Cramer

runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt

@@ -1167,7 +1167,7 @@ class RunnerServiceIntegrationTest : CsmRedisTestBase() {
   }
 
   @Test
-  fun `when sharing a runner, the linked dataset default security should be set to at least viewer if the dataset isn't main`() {
+  fun `when sharing a runner, the linked dataset default security should be set to viewer if the dataset default security is none`() {
     runnerSaved.datasetList!!.removeLast()
     val linkedDatasets = mutableListOf<Dataset>()
     listOf(ROLE_NONE, ROLE_VIEWER, ROLE_USER, ROLE_EDITOR, ROLE_ADMIN).forEach { role ->
@@ -1189,8 +1189,8 @@ class RunnerServiceIntegrationTest : CsmRedisTestBase() {
     runnerApiService.setRunnerDefaultSecurity(
         organizationSaved.id!!, workspaceSaved.id!!, runnerSaved.id!!, RunnerRole(ROLE_EDITOR))
 
-    // Only one result correspond, the dataset with default security none and main=false
-    verify(exactly = 1) { datasetApiService.updateDefaultSecurity(any(), any(), ROLE_VIEWER) }
+    // Only two result correspond, the datasets with default security none
+    verify(exactly = 2) { datasetApiService.updateDefaultSecurity(any(), any(), ROLE_VIEWER) }
   }
 
   @Test

runner/src/main/kotlin/com/cosmotech/runner/service/RunnerService.kt

@@ -518,19 +518,19 @@ class RunnerService(
         val linkedDataset =
             datasetApiService.findByOrganizationIdAndDatasetId(
                 this.runner.organizationId!!, datasetId)
-        if (linkedDataset!!.main == true) return@forEach
+        if (datasetRole == ROLE_NONE && linkedDataset!!.main == true) return@forEach
         // If the dataset default security is different from none,
         // Then it's already viewer or higher and doesn't need to change
-        if (datasetRole == ROLE_VIEWER && linkedDataset.security!!.default != ROLE_NONE)
+        if (datasetRole == ROLE_VIEWER && linkedDataset!!.security!!.default != ROLE_NONE)
             return@forEach
         // If the dataset default security is different from viewer,
         // Then it's either already none or higher than viewer and doesn't need to change
-        if (datasetRole == ROLE_NONE && linkedDataset.security!!.default != ROLE_VIEWER)
+        if (datasetRole == ROLE_NONE && linkedDataset!!.security!!.default != ROLE_VIEWER)
             return@forEach
         // Filter on dataset copy (because we do not want to update main dataset as it can be shared
         // between runners)
         datasetApiService.updateDefaultSecurity(
-            this.runner.organizationId!!, linkedDataset, datasetRole)
+            this.runner.organizationId!!, linkedDataset!!, datasetRole)
       }
     }
   }

scenario/src/integrationTest/kotlin/com/cosmotech/scenario/service/ScenarioServiceIntegrationTest.kt

@@ -1261,7 +1261,7 @@ class ScenarioServiceIntegrationTest : CsmRedisTestBase() {
   }
 
   @Test
-  fun `when sharing a scenario, the linked dataset default security should be set to at least viewer if the dataset isn't main`() {
+  fun `when sharing a scenario, the linked dataset default security should be set to viewer if the dataset default security is none`() {
     scenarioSaved.datasetList!!.removeLast()
     val linkedDatasets = mutableListOf<Dataset>()
     listOf(ROLE_NONE, ROLE_VIEWER, ROLE_USER, ROLE_EDITOR, ROLE_ADMIN).forEach { role ->
@@ -1283,8 +1283,8 @@ class ScenarioServiceIntegrationTest : CsmRedisTestBase() {
     scenarioApiService.setScenarioDefaultSecurity(
         organizationSaved.id!!, workspaceSaved.id!!, scenarioSaved.id!!, ScenarioRole(ROLE_EDITOR))
 
-    // Only one result correspond, the dataset with default security none and main=false
-    verify(exactly = 1) { datasetApiService.updateDefaultSecurity(any(), any(), ROLE_VIEWER) }
+    // Only two result correspond, the datasets with default security none
+    verify(exactly = 2) { datasetApiService.updateDefaultSecurity(any(), any(), ROLE_VIEWER) }
   }
 
   @Test

scenario/src/main/kotlin/com/cosmotech/scenario/service/ScenarioServiceImpl.kt

@@ -1169,13 +1169,13 @@ internal class ScenarioServiceImpl(
     if (scenarioRole == ROLE_NONE) datasetRole = ROLE_NONE
     scenario.datasetList!!.forEach { datasetId ->
       val dataset = datasetService.findByOrganizationIdAndDatasetId(organizationId, datasetId)
-      if (dataset!!.main == true) return@forEach
+      if (datasetRole == ROLE_NONE && dataset!!.main == true) return@forEach
       // We do not want to lower the default security if it's higher than viewer
-      if (datasetRole == ROLE_VIEWER && dataset.security!!.default != ROLE_NONE) return@forEach
-      if (datasetRole == ROLE_NONE && dataset.security!!.default != ROLE_VIEWER) return@forEach
+      if (datasetRole == ROLE_VIEWER && dataset!!.security!!.default != ROLE_NONE) return@forEach
+      if (datasetRole == ROLE_NONE && dataset!!.security!!.default != ROLE_VIEWER) return@forEach
       // Filter on dataset copy (because we do not want to update main dataset as it can be shared
       // between scenarios)
-      datasetService.updateDefaultSecurity(organizationId, dataset, datasetRole)
+      datasetService.updateDefaultSecurity(organizationId, dataset!!, datasetRole)
     }
   }