Skip to content

Commit 3302ddc

Browse files
sjoubertsjoubert
committed
Remove unused 'regexValidation' field on solution parameter
1 parent a17b4f9 commit 3302ddc

File tree

8 files changed

+0
-57
lines changed

8 files changed

+0
-57
lines changed

‎api/src/integrationTest/kotlin/com/cosmotech/api/home/solution/SolutionControllerTests.kt‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ class SolutionControllerTests : ControllerTestBase() {
124124
val parameterGroupDescription = "this_is_a_description"
125125
val parameterMinValue = "this_is_a_minimal_value"
126126
val parameterMaxValue = "this_is_a_maximal_value"
127-
val parameterRegexValidation = "this_is_a_regex_to_validate_value"
128127
val additionalData =
129128
mutableMapOf(
130129
"you_can_put" to "whatever_you_want_here",
@@ -139,7 +138,6 @@ class SolutionControllerTests : ControllerTestBase() {
139138
parameterDefaultValue,
140139
parameterMinValue,
141140
parameterMaxValue,
142-
parameterRegexValidation,
143141
additionalData))
144142
val parameterGroupId = "parameterGroup1"
145143
val parameterGroups =
@@ -213,7 +211,6 @@ class SolutionControllerTests : ControllerTestBase() {
213211
.andExpect(jsonPath("$.parameters[0].defaultValue").value(parameterDefaultValue))
214212
.andExpect(jsonPath("$.parameters[0].minValue").value(parameterMinValue))
215213
.andExpect(jsonPath("$.parameters[0].maxValue").value(parameterMaxValue))
216-
.andExpect(jsonPath("$.parameters[0].regexValidation").value(parameterRegexValidation))
217214
.andExpect(jsonPath("$.parameterGroups[0].id").value(parameterGroupId))
218215
.andExpect(jsonPath("$.parameterGroups[0].labels").value(parameterLabels))
219216
.andExpect(jsonPath("$.parameterGroups[0].parameters").value(mutableListOf(parameterId)))
@@ -256,7 +253,6 @@ class SolutionControllerTests : ControllerTestBase() {
256253
val parameterDefaultValue = "this_is_a_default_value"
257254
val parameterMinValue = "this_is_a_minimal_value"
258255
val parameterMaxValue = "this_is_a_maximal_value"
259-
val parameterRegexValidation = "this_is_a_regex_to_validate_value"
260256
val additionalData =
261257
mutableMapOf(
262258
"you_can_put" to "whatever_you_want_here",
@@ -271,7 +267,6 @@ class SolutionControllerTests : ControllerTestBase() {
271267
parameterDefaultValue,
272268
parameterMinValue,
273269
parameterMaxValue,
274-
parameterRegexValidation,
275270
additionalData))
276271
val parameterGroupId = "parameterGroup1"
277272
val parameterGroupDescription = "this_is_a_description"
@@ -347,7 +342,6 @@ class SolutionControllerTests : ControllerTestBase() {
347342
.andExpect(jsonPath("$.parameters[0].defaultValue").value(parameterDefaultValue))
348343
.andExpect(jsonPath("$.parameters[0].minValue").value(parameterMinValue))
349344
.andExpect(jsonPath("$.parameters[0].maxValue").value(parameterMaxValue))
350-
.andExpect(jsonPath("$.parameters[0].regexValidation").value(parameterRegexValidation))
351345
.andExpect(
352346
jsonPath("$.parameters[0].additionalData[\"you_can_put\"]")
353347
.value("whatever_you_want_here"))
@@ -461,7 +455,6 @@ class SolutionControllerTests : ControllerTestBase() {
461455
val parameterDefaultValue = "this_is_a_default_value"
462456
val parameterMinValue = "this_is_a_minimal_value"
463457
val parameterMaxValue = "this_is_a_maximal_value"
464-
val parameterRegexValidation = "this_is_a_regex_to_validate_value"
465458
val additionalData =
466459
mutableMapOf(
467460
"you_can_put" to "whatever_you_want_here",
@@ -475,7 +468,6 @@ class SolutionControllerTests : ControllerTestBase() {
475468
parameterDefaultValue,
476469
parameterMinValue,
477470
parameterMaxValue,
478-
parameterRegexValidation,
479471
additionalData)
480472

481473
val solutionId =
@@ -494,7 +486,6 @@ class SolutionControllerTests : ControllerTestBase() {
494486
.andExpect(jsonPath("$.defaultValue").value(parameterDefaultValue))
495487
.andExpect(jsonPath("$.minValue").value(parameterMinValue))
496488
.andExpect(jsonPath("$.maxValue").value(parameterMaxValue))
497-
.andExpect(jsonPath("$.regexValidation").value(parameterRegexValidation))
498489
.andExpect(jsonPath("$.additionalData[\"you_can_put\"]").value("whatever_you_want_here"))
499490
.andExpect(jsonPath("$.additionalData[\"even\"][\"object\"]").value("if_you_want"))
500491
.andDo(MockMvcResultHandlers.print())
@@ -512,7 +503,6 @@ class SolutionControllerTests : ControllerTestBase() {
512503
val parameterDefaultValue = "this_is_a_default_value"
513504
val parameterMinValue = "this_is_a_minimal_value"
514505
val parameterMaxValue = "this_is_a_maximal_value"
515-
val parameterRegexValidation = "this_is_a_regex_to_validate_value"
516506
val additionalData =
517507
mutableMapOf(
518508
"you_can_put" to "whatever_you_want_here",
@@ -526,7 +516,6 @@ class SolutionControllerTests : ControllerTestBase() {
526516
parameterDefaultValue,
527517
parameterMinValue,
528518
parameterMaxValue,
529-
parameterRegexValidation,
530519
additionalData)
531520

532521
val solutionId =
@@ -550,7 +539,6 @@ class SolutionControllerTests : ControllerTestBase() {
550539
.andExpect(jsonPath("$.defaultValue").value(parameterDefaultValue))
551540
.andExpect(jsonPath("$.minValue").value(parameterMinValue))
552541
.andExpect(jsonPath("$.maxValue").value(parameterMaxValue))
553-
.andExpect(jsonPath("$.regexValidation").value(parameterRegexValidation))
554542
.andExpect(jsonPath("$.additionalData[\"you_can_put\"]").value("whatever_you_want_here"))
555543
.andExpect(jsonPath("$.additionalData[\"even\"][\"object\"]").value("if_you_want"))
556544
.andDo(MockMvcResultHandlers.print())
@@ -570,7 +558,6 @@ class SolutionControllerTests : ControllerTestBase() {
570558
val newParameterDefaultValue = "this_is_a_new_default_value"
571559
val newParameterMinValue = "this_is_a_new_minimal_value"
572560
val newParameterMaxValue = "this_is_a_new_maximal_value"
573-
val newParameterRegexValidation = "this_is_a_new_regex_to_validate_value"
574561
val newParameterAdditionalData =
575562
mutableMapOf(
576563
"new_you_can_put" to "new_whatever_you_want_here",
@@ -584,7 +571,6 @@ class SolutionControllerTests : ControllerTestBase() {
584571
newParameterDefaultValue,
585572
newParameterMinValue,
586573
newParameterMaxValue,
587-
newParameterRegexValidation,
588574
newParameterAdditionalData)
589575

590576
val solutionId =
@@ -602,7 +588,6 @@ class SolutionControllerTests : ControllerTestBase() {
602588
"this_is_a_default_value",
603589
"this_is_a_minimal_value",
604590
"this_is_a_maximal_value",
605-
"this_is_a_regex_to_validate_value",
606591
mutableMapOf(
607592
"you_can_put" to "whatever_you_want_here",
608593
"even" to JSONObject(mapOf("object" to "if_you_want")))))))
@@ -620,7 +605,6 @@ class SolutionControllerTests : ControllerTestBase() {
620605
.andExpect(jsonPath("$.defaultValue").value(newParameterDefaultValue))
621606
.andExpect(jsonPath("$.minValue").value(newParameterMinValue))
622607
.andExpect(jsonPath("$.maxValue").value(newParameterMaxValue))
623-
.andExpect(jsonPath("$.regexValidation").value(newParameterRegexValidation))
624608
.andExpect(
625609
jsonPath("$.additionalData[\"new_you_can_put\"]").value("new_whatever_you_want_here"))
626610
.andExpect(
@@ -642,7 +626,6 @@ class SolutionControllerTests : ControllerTestBase() {
642626
val parameterDefaultValue = "this_is_a_default_value"
643627
val parameterMinValue = "this_is_a_minimal_value"
644628
val parameterMaxValue = "this_is_a_maximal_value"
645-
val parameterRegexValidation = "this_is_a_regex_to_validate_value"
646629
val additionalData =
647630
mutableMapOf(
648631
"you_can_put" to "whatever_you_want_here",
@@ -657,7 +640,6 @@ class SolutionControllerTests : ControllerTestBase() {
657640
parameterDefaultValue,
658641
parameterMinValue,
659642
parameterMaxValue,
660-
parameterRegexValidation,
661643
additionalData))
662644
val solutionId =
663645
createSolutionAndReturnId(
@@ -674,7 +656,6 @@ class SolutionControllerTests : ControllerTestBase() {
674656
.andExpect(jsonPath("$[0].defaultValue").value(parameterDefaultValue))
675657
.andExpect(jsonPath("$[0].minValue").value(parameterMinValue))
676658
.andExpect(jsonPath("$[0].maxValue").value(parameterMaxValue))
677-
.andExpect(jsonPath("$[0].regexValidation").value(parameterRegexValidation))
678659
.andExpect(jsonPath("$[0].additionalData[\"you_can_put\"]").value("whatever_you_want_here"))
679660
.andExpect(jsonPath("$[0].additionalData[\"even\"][\"object\"]").value("if_you_want"))
680661
.andDo(document("organizations/{organization_id}/solutions/{solution_id}/parameters/GET"))
@@ -691,7 +672,6 @@ class SolutionControllerTests : ControllerTestBase() {
691672
val parameterDefaultValue = "this_is_a_default_value"
692673
val parameterMinValue = "this_is_a_minimal_value"
693674
val parameterMaxValue = "this_is_a_maximal_value"
694-
val parameterRegexValidation = "this_is_a_regex_to_validate_value"
695675
val additionalData =
696676
mutableMapOf(
697677
"you_can_put" to "whatever_you_want_here",
@@ -706,7 +686,6 @@ class SolutionControllerTests : ControllerTestBase() {
706686
parameterDefaultValue,
707687
parameterMinValue,
708688
parameterMaxValue,
709-
parameterRegexValidation,
710689
additionalData))
711690
val solutionId =
712691
createSolutionAndReturnId(

‎doc/Models/RunTemplateParameter.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
| **defaultValue** | **String** | The default value for this parameter | [optional] [default to null] |
1111
| **minValue** | **String** | The minimum value for this parameter | [optional] [default to null] |
1212
| **maxValue** | **String** | The maximum value for this parameter | [optional] [default to null] |
13-
| **regexValidation** | **String** | A regex to validate the value | [optional] [default to null] |
1413
| **additionalData** | [**Map**](AnyType.md) | Free form additional data | [optional] [default to null] |
1514

1615
[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

‎doc/Models/RunTemplateParameterCreateRequest.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
| **defaultValue** | **String** | The default value for this parameter | [optional] [default to null] |
1111
| **minValue** | **String** | The minimum value for this parameter | [optional] [default to null] |
1212
| **maxValue** | **String** | The maximum value for this parameter | [optional] [default to null] |
13-
| **regexValidation** | **String** | A regex to validate the value | [optional] [default to null] |
1413
| **additionalData** | [**Map**](AnyType.md) | Free form additional data | [optional] [default to null] |
1514

1615
[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

‎doc/Models/RunTemplateParameterUpdateRequest.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
| **defaultValue** | **String** | The default value for this parameter | [optional] [default to null] |
1010
| **minValue** | **String** | The minimum value for this parameter | [optional] [default to null] |
1111
| **maxValue** | **String** | The maximum value for this parameter | [optional] [default to null] |
12-
| **regexValidation** | **String** | A regex to validate the value | [optional] [default to null] |
1312
| **additionalData** | [**Map**](AnyType.md) | Free form additional data | [optional] [default to null] |
1413

1514
[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

‎openapi/plantuml/schemas.plantuml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ entity RunTemplateParameter {
286286
defaultValue: String
287287
minValue: String
288288
maxValue: String
289-
regexValidation: String
290289
additionalData: Map
291290
}
292291

@@ -298,7 +297,6 @@ entity RunTemplateParameterCreateRequest {
298297
defaultValue: String
299298
minValue: String
300299
maxValue: String
301-
regexValidation: String
302300
additionalData: Map
303301
}
304302

@@ -332,7 +330,6 @@ entity RunTemplateParameterUpdateRequest {
332330
defaultValue: String
333331
minValue: String
334332
maxValue: String
335-
regexValidation: String
336333
additionalData: Map
337334
}
338335

0 commit comments

Comments
 (0)