Skip to content

Commit 5229d1d

Browse files
Changes base on the code review
1 parent dbde448 commit 5229d1d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

scenariorun/src/main/kotlin/com/cosmotech/scenariorun/service/ScenarioRunServiceImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ class ScenarioRunServiceImpl(
692692
workflowName = scenariorRunStatus.workflowName,
693693
startTime = scenariorRunStatus.startTime,
694694
endTime = scenariorRunStatus.endTime,
695-
phase = "Failed",
695+
phase = scenariorRunStatus.state.toString(),
696696
progress = scenariorRunStatus.progress,
697697
message = scenariorRunStatus.message,
698698
estimatedDuration = scenariorRunStatus.estimatedDuration,

scenariorun/src/main/kotlin/com/cosmotech/scenariorun/workflow/argo/ArgoWorkflowService.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,8 @@ internal class ArgoWorkflowService(
439439
startTime = workflowStatus?.startedAt?.toString(),
440440
endTime = workflowStatus?.finishedAt?.toString(),
441441
phase =
442-
if (scenarioRun.state == ScenarioRunState.Failed) "Failed" else workflowStatus?.phase,
442+
if (scenarioRun.state == ScenarioRunState.Failed) ScenarioRunState.Failed.toString()
443+
else workflowStatus?.phase,
443444
progress = workflowStatus?.progress,
444445
message = workflowStatus?.message,
445446
estimatedDuration = workflowStatus?.estimatedDuration,

0 commit comments

Comments
 (0)