[PROD-14190] fix "Dataset cannot be found in Datasets" error 500 when a scenario parameter %DATASET_ID% is empty

jreynard-code · jreynard-code · commit 59e46f75ab50 · 2025-01-24T09:12:58.000+01:00
diff --git a/scenariorun/src/main/kotlin/com/cosmotech/scenariorun/ContainerFactory.kt b/scenariorun/src/main/kotlin/com/cosmotech/scenariorun/ContainerFactory.kt
@@ -1125,7 +1125,7 @@ class ContainerFactory(
             }
                 ?: throw IllegalStateException(
                     "Parameter ${parameterValue.parameterId} not found in Solution ${solution.id}")
-        if (parameter.varType == PARAMETERS_DATASET_ID) {
+        if (parameter.varType == PARAMETERS_DATASET_ID && parameterValue.value.isNotBlank()) {
           val datasetIdList = getDatasetIdListFromValue(parameterValue.value)
           datasetIdList.forEachIndexed { index, datasetId ->
             val dataset =

Original file line number	Diff line number	Diff line change
`@@ -1125,7 +1125,7 @@ class ContainerFactory(`
`1125`	`1125`	`}`
`1126`	`1126`	`?: throw IllegalStateException(`
`1127`	`1127`	`"Parameter ${parameterValue.parameterId} not found in Solution ${solution.id}")`
`1128`		`- if (parameter.varType == PARAMETERS_DATASET_ID) {`
	`1128`	`+ if (parameter.varType == PARAMETERS_DATASET_ID && parameterValue.value.isNotBlank()) {`
`1129`	`1129`	`val datasetIdList = getDatasetIdListFromValue(parameterValue.value)`
`1130`	`1130`	`datasetIdList.forEachIndexed { index, datasetId ->`
`1131`	`1131`	`val dataset =`