[PROD-12947] Add integration tests

Author: jreynard-code

dataset/src/integrationTest/kotlin/com/cosmotech/dataset/service/DatasetServiceIntegrationTest.kt

@@ -397,6 +397,48 @@ class DatasetServiceIntegrationTest : CsmRedisTestBase() {
     assertEquals(0, datasetList.size)
   }
 
+  @Test
+  fun `PROD-12947 - test find All Datasets as Organization User`() {
+    organizationSaved = organizationApiService.registerOrganization(organization)
+
+    // Create a dataset that current user should not see because he does not have permission to
+    val numberOfDatasets = 200
+    IntRange(1, numberOfDatasets).forEach {
+      datasetApiService.createDataset(
+          organizationSaved.id!!,
+          makeDatasetWithRole(
+              organizationId = organizationSaved.id!!, userName = "[email protected]"))
+    }
+
+    // Explicitly set connected user information
+    every { getCurrentAccountIdentifier(any()) } returns TEST_USER_MAIL
+    every { getCurrentAuthenticatedUserName(csmPlatformProperties) } returns "test.user"
+    every { getCurrentAuthenticatedRoles(any()) } returns listOf(ROLE_ORGANIZATION_USER)
+
+    logger.info("should not find a dataset because of lake of permission")
+    var datasetList = datasetApiService.findAllDatasets(organizationSaved.id!!, null, null)
+    assertEquals(0, datasetList.size)
+
+    // Create a dataset that current user should not see because it has been created under another
+    // organization
+    val newOrganization = organizationApiService.registerOrganization(makeOrganizationWithRole())
+    val datasetNotReachableByCurrentUserBecausePartOfAnotherOrganization =
+        datasetApiService.createDataset(
+            newOrganization.id!!, makeDatasetWithRole(organizationId = newOrganization.id!!))
+    assertNotNull(datasetNotReachableByCurrentUserBecausePartOfAnotherOrganization)
+    logger.info(
+        "should not find a dataset because:" +
+            " one was created with no permission assigned " +
+            " one was created in another organization")
+    datasetList = datasetApiService.findAllDatasets(organizationSaved.id!!, null, null)
+    assertEquals(0, datasetList.size)
+
+    logger.info("should find only one dataset")
+    datasetList = datasetApiService.findAllDatasets(newOrganization.id!!, null, null)
+    assertEquals(1, datasetList.size)
+    assertEquals(datasetNotReachableByCurrentUserBecausePartOfAnotherOrganization, datasetList[0])
+  }
+
   @Test
   fun `test find All Datasets with different pagination params`() {
     organizationSaved = organizationApiService.registerOrganization(organization)

dataset/src/main/kotlin/com/cosmotech/dataset/repository/DatasetRepository.kt

@@ -20,7 +20,7 @@ interface DatasetRepository : RedisDocumentRepository<Dataset, String> {
       @Sanitize @Param("datasetId") datasetId: String
   ): Optional<Dataset>
 
-  @Query("(@organizationId:{\$organizationId})  \$securityConstraint")
+  @Query("(@organizationId:{\$organizationId}) \$securityConstraint")
   fun findByOrganizationId(
       @Sanitize @Param("organizationId") organizationId: String,
       @SecurityConstraint @Param("securityConstraint") securityConstraint: String,

runner/src/main/kotlin/com/cosmotech/runner/service/RunnerService.kt

@@ -49,6 +49,7 @@ import org.springframework.stereotype.Component
 
 @Component
 @Scope("prototype")
+@Suppress("TooManyFunctions")
 class RunnerService(
     private val runnerRepository: RunnerRepository,
     private val organizationApiService: OrganizationApiServiceInterface,
@@ -228,7 +229,7 @@ class RunnerService(
           runner.runTemplateId!!))
           throw IllegalArgumentException("Run Template not found: ${runner.runTemplateId}")
 
-      val beforeMutateDatasetList = this.runner.datasetList
+      val beforeMutateDatasetList = this.runner.datasetList ?: mutableListOf()
 
       val excludeFields =
           arrayOf(