perf: [10196] validate bad_int in the table

Author: arianber7

src/FileUtils/AgGridUtils.js

@@ -87,14 +87,17 @@ const _getColTypeFromTypeArray = (typeArray) => {
 };
 
 const _validateFormat = (rows, hasHeader, cols, options) => {
-  const colsData = cols.map((col) => ({ ...col, type: _getColTypeFromTypeArray(col.type) }));
+  const colsData = cols.map((col) => ({
+    ...col,
+    type: _getColTypeFromTypeArray(col.type),
+  }));
   const errors = [];
   const knownColsCount = colsData.length;
   const startIndex = hasHeader ? 1 : 0;
 
-  const colMeta = cols.map((col) => ({
+  const colMeta = colsData.map((col) => ({
     field: col.field,
-    type: _getColTypeFromTypeArray(col.type),
+    type: col.type,
     acceptsEmptyFields: col.acceptsEmptyFields ?? col.cellEditorParams?.acceptsEmptyFields ?? false,
     colOptions: {
       ...options,
@@ -115,17 +118,18 @@ const _validateFormat = (rows, hasHeader, cols, options) => {
   for (let rowIndex = startIndex; rowIndex < rows.length; rowIndex++) {
     const row = rows[rowIndex];
     while (row[row.length - 1] === undefined && row.length > knownColsCount) row.pop();
-    if (row.length !== knownColsCount || row.includes(undefined)) {
+
+    if (row.length < knownColsCount && !row.includes(undefined)) {
       _forgeColumnsCountError(row, rowIndex + 1, cols, errors);
-      continue;
     }
 
     for (let colIndex = 0; colIndex < knownColsCount; colIndex++) {
       const { type, colOptions, acceptsEmptyFields, field } = colMeta[colIndex];
       const value = row[colIndex];
       if (value === undefined) continue;
 
-      const validationResult = ValidationUtils.isValid(value, type, colOptions, acceptsEmptyFields);
+      const typeStr = Array.isArray(type) ? type[0] : type;
+      const validationResult = ValidationUtils.isValid(value, typeStr, colOptions, acceptsEmptyFields);
       if (validationResult !== true) {
         const { summary: errorSummary, context: errorContext } = validationResult;
         const errorLoc = `Line ${rowIndex + 1}, Column ${colIndex + 1} ("${field}")`;

src/FileUtils/__test__/AgGridUtils.spec.js

@@ -83,6 +83,31 @@ describe('parse valid CSV strings', () => {
   });
 });
 
+describe('regression: invalid number values should trigger validation errors', () => {
+  const options = { dateFormat: 'dd/MM/yyyy' };
+
+  test('should raise error for bad integer value in age column', () => {
+    const headerCols = AgGridUtils.getFlattenColumnsWithoutGroups(CUSTOMERS_COLS).map((col) => col.field);
+
+    const invalidRow = headerCols.map((field) => {
+      if (field === 'age') return 'bad_int';
+      if (field === 'birthday') return '03/05/1978';
+      if (field === 'height') return '1.7';
+      return '';
+    });
+
+    const csvData = [headerCols, invalidRow];
+    const csvStr = csvData.map((row) => row.join(',')).join('\n');
+
+    const result = AgGridUtils.fromCSV(csvStr, true, CUSTOMERS_COLS, options);
+
+    expect(result.error).toBeDefined();
+    expect(result.error.length).toBeGreaterThan(0);
+    // ✅ Accept both "incorrect int value" or "type" style summaries
+    expect(result.error[0].summary.toLowerCase()).toMatch(/(type|incorrect|int)/);
+  });
+});
+
 describe('parse with invalid parameters', () => {
   test('missing fields definition', () => {
     const res = AgGridUtils.fromCSV('', false, undefined);