perf: [10196] imporve perfromance of CSV parsing table

Author: arianber7

src/FileUtils/AgGridUtils.js

@@ -85,41 +85,59 @@ const _getColTypeFromTypeArray = (typeArray) => {
   return 'string'; // Fall back to default type
 };
 
+const fastIsDate = (value) => typeof value === 'string' && /^\d{4}-\d{2}-\d{2}$/.test(value);
+
 const _validateFormat = (rows, hasHeader, cols, options) => {
-  const colsData = cols.map((col) => ({ ...col, type: _getColTypeFromTypeArray(col.type) }));
   const errors = [];
-  const knownColsCount = colsData.length;
+  const knownColsCount = cols.length;
   const startIndex = hasHeader ? 1 : 0;
+
+  const colMeta = cols.map((col) => ({
+    field: col.field,
+    type: _getColTypeFromTypeArray(col.type),
+    acceptsEmptyFields: col.acceptsEmptyFields ?? col.cellEditorParams?.acceptsEmptyFields ?? false,
+    colOptions: {
+      ...options,
+      enumValues: col.enumValues ?? col.cellEditorParams?.enumValues,
+      minValue: col.minValue,
+      maxValue: col.maxValue,
+    },
+  }));
+
   for (let rowIndex = startIndex; rowIndex < rows.length; rowIndex++) {
     const row = rows[rowIndex];
     while (row[row.length - 1] === undefined && row.length > knownColsCount) row.pop();
-    if (row.length !== knownColsCount || row.includes(undefined))
-      _forgeColumnsCountError(row, rowIndex + 1, colsData, errors);
-    row.forEach((rowCell, colIndex) => {
-      if (colIndex < knownColsCount) {
-        const colType = colsData[colIndex].type;
-        if (colType && rowCell !== undefined) {
-          // use of cellEditorParams is deprecated
-          const colOptions = {
-            ...options,
-            enumValues: colsData[colIndex]?.enumValues ?? colsData[colIndex]?.cellEditorParams?.enumValues,
-            minValue: colsData[colIndex]?.minValue,
-            maxValue: colsData[colIndex]?.maxValue,
-          };
-          const acceptsEmptyFields =
-            // use of cellEditorParams is deprecated
-            colsData[colIndex].acceptsEmptyFields ?? colsData[colIndex].cellEditorParams?.acceptsEmptyFields ?? false;
-          const validationResult = ValidationUtils.isValid(rowCell, colType, colOptions, acceptsEmptyFields);
-          if (validationResult !== true) {
-            const { summary: errorSummary, context: errorContext } = validationResult;
-            const errorLoc = `Line ${rowIndex + 1}, Column ${colIndex + 1} ("${colsData[colIndex].field}")`;
-            errors.push(new PanelError(errorSummary, errorLoc, errorContext));
-          }
+    if (row.length !== knownColsCount || row.includes(undefined)) {
+      _forgeColumnsCountError(row, rowIndex + 1, cols, errors);
+      continue;
+    }
+
+    for (let colIndex = 0; colIndex < knownColsCount; colIndex++) {
+      const { type, colOptions, acceptsEmptyFields, field } = colMeta[colIndex];
+      const value = row[colIndex];
+      if (value === undefined) continue;
+
+      if (type === 'date' && value !== undefined) {
+        if (!fastIsDate(value)) {
+          errors.push(
+            new PanelError(
+              'Invalid date format',
+              `Line ${rowIndex + 1}, Column ${colIndex + 1} ("${field}")`,
+              `Value "${value}" is not a valid date (expected format yyyy-MM-dd)`
+            )
+          );
         }
+        return;
       }
-    });
-  }
 
+      const validationResult = ValidationUtils.isValid(value, type, colOptions, acceptsEmptyFields);
+      if (validationResult !== true) {
+        const { summary: errorSummary, context: errorContext } = validationResult;
+        const errorLoc = `Line ${rowIndex + 1}, Column ${colIndex + 1} ("${field}")`;
+        errors.push(new PanelError(errorSummary, errorLoc, errorContext));
+      }
+    }
+  }
   return errors;
 };