perf: [PROD-10196] convert min & max dates before validating all rows

Author: csm-thu

src/FileUtils/AgGridUtils.js

@@ -1,5 +1,6 @@
 // Copyright (c) Cosmo Tech.
 // Licensed under the MIT license.
+import DateUtils from '../DateUtils/DateUtils';
 import { ValidationUtils } from '../ValidationUtils';
 import { Error as PanelError } from '../models';
 import CSV from './CSVUtils';
@@ -101,6 +102,14 @@ const _validateFormat = (rows, hasHeader, cols, options) => {
       maxValue: col.maxValue,
     },
   }));
+  // For date columns, convert min & max values to do it only once
+  colMeta.forEach((col) => {
+    if (col.type === 'date' && options?.dateFormat) {
+      const colOptions = col.colOptions;
+      if (colOptions.minValue != null) colOptions.minDate = DateUtils.parse(colOptions.minValue, options?.dateFormat);
+      if (colOptions.maxValue != null) colOptions.maxDate = DateUtils.parse(colOptions.maxValue, options?.dateFormat);
+    }
+  });
 
   for (let rowIndex = startIndex; rowIndex < rows.length; rowIndex++) {
     const row = rows[rowIndex];

src/ValidationUtils/ValidationUtils.js

@@ -69,9 +69,7 @@ const castToDate = (dateOrStrValue, dateFormat) => {
   return DateUtils.parse(dateOrStrValue, dateFormat);
 };
 
-const isDateInRange = (value, minValue, maxValue, dateFormat) => {
-  const minDate = castToDate(minValue, dateFormat);
-  const maxDate = castToDate(maxValue, dateFormat);
+const isDateInRange = (value, minDate, maxDate, dateFormat) => {
   const format = DateUtils.format;
   if (value == null) return null;
   if (dateFormat == null) return forgeConfigError("Missing option dateFormat, can't perform date validation.");
@@ -97,8 +95,11 @@ const isValid = (dataStr, type, options, canBeEmpty = false) => {
       if (!options?.dateFormat) return forgeConfigError("Missing option dateFormat, can't perform date validation.");
 
       const valueAsDate = DateUtils.parse(dataStr, options?.dateFormat);
-      if (isNaN(valueAsDate.getTime())) return forgeTypeError(dataStr, type, options);
-      return isDateInRange(valueAsDate, options?.minValue, options?.maxValue, options?.dateFormat);
+      if (isNaN(valueAsDate.getTime())) return forgeTypeError(dataStr, type, options); // Invalid date
+
+      const minDate = options?.minDate ?? castToDate(options?.minValue, options?.dateFormat);
+      const maxDate = options?.maxDate ?? castToDate(options?.maxValue, options?.dateFormat);
+      return isDateInRange(valueAsDate, minDate, maxDate, options?.dateFormat);
     }
     case 'enum':
       if (!options.enumValues) return forgeConfigError("Missing option enumValues, can't perform enum validation.");