fix: [FIXUP]

Author: csm-thu

src/charts/SupersetReport/SupersetReport.js

@@ -7,12 +7,19 @@ import { embedDashboard } from '@superset-ui/embedded-sdk';
 import { PowerBIUtils } from '@cosmotech/azure';
 import { useDashboardPlaceholder } from '../DashboardPlaceholder/useDashboardPlaceholder';
 
+export const SUPERSET_GUEST_TOKEN_STATUS = {
+  IDLE: 'IDLE',
+  LOADING: 'LOADING',
+  ERROR: 'ERROR',
+  SUCCESS: 'SUCCESS',
+};
+
 export const SupersetReport = ({
   alwaysShowReports = false,
   disabled = false,
+  isParentLoading = false,
   downloadLogsFile,
   guestToken,
-  isLoading = false,
   noDashboardConfigured = false,
   labels,
   options,
@@ -22,21 +29,23 @@ export const SupersetReport = ({
   visibleScenarios,
 }) => {
   const containerRef = useRef(null);
-  const tokenRef = useRef(guestToken);
+  const tokenRef = useRef(null);
   const [isEmbedded, setIsEmbedded] = useState(false);
   const [dashboard, setDashboard] = useState(null);
 
   const { getDashboardPlaceholder } = useDashboardPlaceholder();
 
   useEffect(() => {
-    tokenRef.current = guestToken;
-  }, [guestToken]);
+    if (guestToken?.status !== SUPERSET_GUEST_TOKEN_STATUS.SUCCESS) return;
+
+    tokenRef.current = guestToken?.value;
+  }, [guestToken?.status, guestToken?.value]);
 
   useEffect(() => {
     if (!report?.id || !options?.supersetUrl) return;
 
     const loadSuperset = async () => {
-      if (isEmbedded || guestToken == null || guestToken === '') return;
+      if (isEmbedded || guestToken?.status !== SUPERSET_GUEST_TOKEN_STATUS.SUCCESS) return;
 
       try {
         const embedded = await embedDashboard({
@@ -92,7 +101,11 @@ export const SupersetReport = ({
   const containerHeight = isReportVisible ? (report?.height ?? style?.height ?? '800px') : '100%';
   const containerWidth = isReportVisible ? (report?.width ?? style?.width ?? '100%') : '100%';
   const reportContainerDisplay = isReportVisible ? undefined : 'none';
-  const showLoadingSpinner = placeholder == null && (isLoading || !isEmbedded);
+  const showLoadingSpinner =
+    !isParentLoading &&
+    guestToken?.status !== SUPERSET_GUEST_TOKEN_STATUS.ERROR &&
+    placeholder == null &&
+    (!isEmbedded || guestToken?.status === SUPERSET_GUEST_TOKEN_STATUS.LOADING);
 
   return (
     <Box sx={{ position: 'relative', width: containerWidth, height: containerHeight, overflow: 'hidden' }}>
@@ -115,9 +128,12 @@ export const SupersetReport = ({
 SupersetReport.propTypes = {
   alwaysShowReports: PropTypes.bool,
   disabled: PropTypes.bool,
+  isParentLoading: PropTypes.bool,
   downloadLogsFile: PropTypes.func,
-  guestToken: PropTypes.string.isRequired,
-  isLoading: PropTypes.bool,
+  // guestToken: object with shape {value, status}
+  //  - value: (string) token value
+  //  - status: (string) status of the token retrieval process ("IDLE", "LOADING", "ERROR", "SUCCESS")
+  guestToken: PropTypes.shape({ value: PropTypes.string.isRequired, status: PropTypes.string.isRequired }).isRequired,
   labels: PropTypes.object,
   noDashboardConfigured: PropTypes.bool,
   options: PropTypes.shape({ supersetUrl: PropTypes.string.isRequired }).isRequired,