Skip to content

Commit 60e708b

Browse files
fix: tests, changelog and new test about it
1 parent 8d01073 commit 60e708b

File tree

3 files changed

+111
-36
lines changed

3 files changed

+111
-36
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
## 24.7.7
2+
* ! Minor breaking change ! Going forward, only the first page viewed in a session will have a 'start' parameter. Pages viewed outside of a session will no longer include this parameter.
3+
24
* Mitigated an issue where an automaticly closed autostopped view's duration could have increased when opening new views
35
* Mitigated an issue where, on Android 35 and above, the navigation bar was overlapping with the content display.
46

sdk/src/androidTest/java/ly/count/android/sdk/ModuleEventsTests.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,8 @@ public void recordEventScenario_previous_current_ViewName_disabled() throws JSON
899899
countly.views().startView("View1");
900900
countly.events().recordEvent("TEST1");
901901

902-
ModuleViewsTests.validateView("View1", 0.0, 1, 3, true, true, TestUtils.map(), "_CLY_", "_CLY_", null);
902+
// start false because session did not start
903+
ModuleViewsTests.validateView("View1", 0.0, 1, 3, false, true, TestUtils.map(), "_CLY_", "_CLY_", null);
903904
validateEventInRQ("TEST1", 2, 3, "_CLY_", "_CLY_", null, null);
904905

905906
countly.views().startView("View2");
@@ -930,7 +931,8 @@ public void recordEventScenario_previous_current_ViewName() throws JSONException
930931
countly.views().startView("View1");
931932
countly.events().recordEvent("TEST1");
932933

933-
ModuleViewsTests.validateView("View1", 0.0, 1, 3, true, true, TestUtils.map(), "_CLY_", "_CLY_", "");
934+
// start false because session did not start
935+
ModuleViewsTests.validateView("View1", 0.0, 1, 3, false, true, TestUtils.map(), "_CLY_", "_CLY_", "");
934936
validateEventInRQ("TEST1", 2, 3, "_CLY_", "_CLY_", "TEST", "View1");
935937

936938
countly.views().startView("View2");

0 commit comments

Comments
 (0)