Merge pull request #337 from Countly/fix_h

fix: enable caching via configuration

Author: turtledreams

CHANGELOG.md

@@ -4,6 +4,7 @@
   * During an internal timer tick
   * Upon flushing the event queue
 
+* Mitigated an issue where remote config values caching was changing by device id change, not anymore. It is linked to the configuration "enableRemoteConfigValueCaching" now.
 * Mitigated an issue related to the device ID by creating an internal migration.
 * Resolved a problem where revoked consents were sent after changes without merging.
 * Fixed a bug that caused the device ID to be incorrectly set after changes with merging.

sdk/src/main/java/ly/count/android/sdk/ModuleDeviceId.java

@@ -129,7 +129,7 @@ void changeDeviceIdWithoutMergeInternal(@NonNull String deviceId) {
         _cly.moduleUserProfile.saveInternal();
 
         //update remote config_ values after id change if automatic update is enabled
-        _cly.moduleRemoteConfig.clearAndDownloadAfterIdChange(true);
+        _cly.moduleRemoteConfig.clearAndDownloadAfterIdChange();
 
         _cly.moduleSessions.endSessionInternal();
 
@@ -189,7 +189,7 @@ void changeDeviceIdWithMergeInternal(@NonNull String deviceId) {
             // in both cases we act the same as the temporary ID requests will be updated with the final ID later
 
             //update remote config_ values after id change if automatic update is enabled
-            _cly.moduleRemoteConfig.clearAndDownloadAfterIdChange(false);
+            _cly.moduleRemoteConfig.clearAndDownloadAfterIdChange();
             requestQueueProvider.changeDeviceId(deviceId, deviceIdInstance.getCurrentId());
             deviceIdInstance.changeToCustomId(deviceId);
             _cly.notifyDeviceIdChange();

sdk/src/main/java/ly/count/android/sdk/ModuleRemoteConfig.java

@@ -381,12 +381,11 @@ void clearValueStoreInternal() {
         return variantResponse;
     }
 
-    void clearAndDownloadAfterIdChange(boolean valuesShouldBeCacheCleared) {
-        L.v("[RemoteConfig] Clearing remote config values and preparing to download after ID update, " + valuesShouldBeCacheCleared);
+    void clearAndDownloadAfterIdChange() {
+        L.v("[RemoteConfig] Clearing remote config values and preparing to download after ID update");
+
+        CacheOrClearRCValuesIfNeeded();
 
-        if (valuesShouldBeCacheCleared) {
-            CacheOrClearRCValuesIfNeeded();
-        }
         if (automaticDownloadTriggersEnabled && consentProvider.getConsent(Countly.CountlyFeatureNames.remoteConfig)) {
             updateRemoteConfigAfterIdChange = true;
         }