fix: do not remove on consent revoke

Author: arifBurakDemiray

sdk/src/androidTest/java/ly/count/android/sdk/ModuleRemoteConfigTests.java

@@ -30,7 +30,7 @@ public void setUp() {
     }
 
     /**
-     * Consent removal should clear stored remote config values
+     * Consent removal shouldn't clear stored remote config values
      */
     @Test
     public void valuesClearedOnConsentRemoval() {
@@ -51,7 +51,7 @@ public void valuesClearedOnConsentRemoval() {
         countly.consent().removeConsentAll();
 
         Assert.assertEquals(2, countly.remoteConfig().getValues().size()); // values are cache cleared
-        countly.remoteConfig().getValues().forEach((k, v) -> Assert.assertFalse(v.isCurrentUsersData));
+        countly.remoteConfig().getValues().forEach((k, v) -> Assert.assertTrue(v.isCurrentUsersData));
     }
 
     /**

sdk/src/main/java/ly/count/android/sdk/ModuleRemoteConfig.java

@@ -426,11 +426,9 @@ void RCAutomaticDownloadTrigger(boolean cacheClearOldValues) {
     void onConsentChanged(@NonNull final List<String> consentChangeDelta, final boolean newConsent, @NonNull final ModuleConsent.ConsentChangeSource changeSource) {
         if (consentChangeDelta.contains(Countly.CountlyFeatureNames.remoteConfig) && changeSource == ChangeConsentCall) {
             if (newConsent) {
+                L.d("[RemoteConfig] onConsentChanged, Consent given, will update RC values");
                 //if consent was just given trigger automatic RC download if needed
                 RCAutomaticDownloadTrigger(false);
-            } else {
-                L.d("[RemoteConfig] removing remote-config consent. Clearing stored values");
-                CacheOrClearRCValuesIfNeeded();
             }
         }
     }