Merge pull request #335 from Countly/fix_3e

fix: do not remove RC on remote-config consent revoke

Author: turtledreams

CHANGELOG.md

@@ -3,6 +3,8 @@
   * When an event is recorded
   * During an internal timer tick
   * Upon flushing the event queue
+ 
+* Mitigated an issue where on consent revoke, remote config values were cleared, not anymore.
 
 * Added support for array, List and JSONArray to all user given segmentations. They will support only mutable and ummutable versions of the primitive types. Which are:
   * String, Integer, int, Boolean, bool, Float, float, Double, double, Long, long

sdk/src/androidTest/java/ly/count/android/sdk/ModuleRemoteConfigTests.java

@@ -30,7 +30,7 @@ public void setUp() {
     }
 
     /**
-     * Consent removal should clear stored remote config values
+     * Consent removal shouldn't clear stored remote config values
      */
     @Test
     public void valuesClearedOnConsentRemoval() {
@@ -50,7 +50,8 @@ public void valuesClearedOnConsentRemoval() {
 
         countly.consent().removeConsentAll();
 
-        Assert.assertEquals(0, countly.remoteConfig().getValues().size());
+        Assert.assertEquals(2, countly.remoteConfig().getValues().size()); // values are cache cleared
+        countly.remoteConfig().getValues().forEach((k, v) -> Assert.assertTrue(v.isCurrentUsersData));
     }
 
     /**

sdk/src/main/java/ly/count/android/sdk/ModuleRemoteConfig.java

@@ -426,12 +426,9 @@ void RCAutomaticDownloadTrigger(boolean cacheClearOldValues) {
     void onConsentChanged(@NonNull final List<String> consentChangeDelta, final boolean newConsent, @NonNull final ModuleConsent.ConsentChangeSource changeSource) {
         if (consentChangeDelta.contains(Countly.CountlyFeatureNames.remoteConfig) && changeSource == ChangeConsentCall) {
             if (newConsent) {
+                L.d("[RemoteConfig] onConsentChanged, Consent given, will update RC values");
                 //if consent was just given trigger automatic RC download if needed
                 RCAutomaticDownloadTrigger(false);
-            } else {
-                L.d("[RemoteConfig] removing remote-config consent. Clearing stored values");
-                clearValueStoreInternal();
-                // if consent is removed, we should clear remote config values
             }
         }
     }