feat: add detailed logs to unsupported data types

Author: arifBurakDemiray

sdk/src/androidTest/java/ly/count/android/sdk/UtilsInternalLimitsTests.java

@@ -244,7 +244,7 @@ public void removeReservedKeysFromSegmentation() {
 
     @Test(expected = AssertionError.class)
     public void removeUnsupportedDataTypesNull() {
-        Assert.assertFalse(UtilsInternalLimits.removeUnsupportedDataTypes(null));
+        Assert.assertFalse(UtilsInternalLimits.removeUnsupportedDataTypes(null, Mockito.mock(ModuleLog.class)));
     }
 
     @Test
@@ -261,7 +261,7 @@ public void removeUnsupportedDataTypes() {
         segm.put("41", new Object());
         segm.put("42", new int[] { 1, 2 });
 
-        Assert.assertTrue(UtilsInternalLimits.removeUnsupportedDataTypes(segm));
+        Assert.assertTrue(UtilsInternalLimits.removeUnsupportedDataTypes(segm, Mockito.mock(ModuleLog.class)));
 
         Assert.assertTrue(segm.containsKey("aa"));
         Assert.assertTrue(segm.containsKey("aa1"));
@@ -284,7 +284,7 @@ public void removeUnsupportedDataTypes2() {
 
         Assert.assertEquals(3, segm.size());
 
-        Assert.assertTrue(UtilsInternalLimits.removeUnsupportedDataTypes(segm));
+        Assert.assertTrue(UtilsInternalLimits.removeUnsupportedDataTypes(segm, Mockito.mock(ModuleLog.class)));
 
         Assert.assertEquals(0, segm.size());
 
@@ -298,7 +298,7 @@ public void removeUnsupportedDataTypes2() {
 
         Assert.assertEquals(7, segm.size());
 
-        Assert.assertTrue(UtilsInternalLimits.removeUnsupportedDataTypes(segm));
+        Assert.assertTrue(UtilsInternalLimits.removeUnsupportedDataTypes(segm, Mockito.mock(ModuleLog.class)));
 
         Assert.assertEquals(4, segm.size());
         Assert.assertTrue(segm.containsKey("1"));

sdk/src/main/java/ly/count/android/sdk/ModuleCrash.java

@@ -256,8 +256,8 @@ boolean crashFilterCheck(@NonNull CrashData crashData) {
         UtilsInternalLimits.applySdkInternalLimitsToSegmentation(crashData.getCrashSegmentation(), _cly.config_.sdkInternalLimits, L, "[ModuleCrash] sendCrashReportToQueue");
         String truncatedStackTrace = UtilsInternalLimits.applyInternalLimitsToStackTraces(crashData.getStackTrace(), _cly.config_.sdkInternalLimits.maxStackTraceLineLength, "[ModuleCrash] sendCrashReportToQueue", L);
         crashData.setStackTrace(truncatedStackTrace);
-        UtilsInternalLimits.removeUnsupportedDataTypes(crashData.getCrashSegmentation());
-        UtilsInternalLimits.removeUnsupportedDataTypes(crashData.getCrashMetrics());
+        UtilsInternalLimits.removeUnsupportedDataTypes(crashData.getCrashSegmentation(), L);
+        UtilsInternalLimits.removeUnsupportedDataTypes(crashData.getCrashMetrics(), L);
 
         return false;
     }

sdk/src/main/java/ly/count/android/sdk/ModuleEvents.java

@@ -88,7 +88,7 @@ public void recordEventInternal(@Nullable final String key, @Nullable Map<String
         L.d("[ModuleEvents] recordEventInternal, key:[" + key + "] eventIdOverride:[" + eventIdOverride + "] segmentation:[" + segmentation + "] count:[" + count + "] sum:[" + sum + "] dur:[" + dur + "] instant:[" + instant + "]");
 
         if (segmentation != null) {
-            UtilsInternalLimits.removeUnsupportedDataTypes(segmentation);
+            UtilsInternalLimits.removeUnsupportedDataTypes(segmentation, L);
         }
 
         //record the current event timestamps
@@ -163,7 +163,7 @@ public void recordEventInternal(@Nullable final String key, @Nullable Map<String
             case ACTION_EVENT_KEY:
                 if (consentProvider.getConsent(Countly.CountlyFeatureNames.clicks) || consentProvider.getConsent(Countly.CountlyFeatureNames.scrolls)) {
                     if (segmentation != null) {
-                        UtilsInternalLimits.removeUnsupportedDataTypes(segmentation);
+                        UtilsInternalLimits.removeUnsupportedDataTypes(segmentation, L);
                     }
                     eventQueueProvider.recordEventToEventQueue(key, segmentation, count, sum, dur, timestamp, hour, dow, eventId, pvid, cvid, null);
                     _cly.moduleRequestQueue.sendEventsIfNeeded(false);

sdk/src/main/java/ly/count/android/sdk/ModuleFeedback.java

@@ -447,7 +447,7 @@ void reportFeedbackWidgetManuallyInternal(@Nullable CountlyFeedbackWidget widget
 
         if (widgetResult != null) {
             //removing broken values first
-            UtilsInternalLimits.removeUnsupportedDataTypes(widgetResult);
+            UtilsInternalLimits.removeUnsupportedDataTypes(widgetResult, L);
 
             Iterator<Map.Entry<String, Object>> iter = widgetResult.entrySet().iterator();
             while (iter.hasNext()) {

sdk/src/main/java/ly/count/android/sdk/UtilsInternalLimits.java

@@ -292,10 +292,10 @@ static void removeReservedKeysFromSegmentation(@NonNull Map<String, Object> segm
      * @param data
      * @return returns true if any entry had been removed
      */
-    static boolean removeUnsupportedDataTypes(@NonNull Map<String, Object> data) {
+    static boolean removeUnsupportedDataTypes(@NonNull Map<String, Object> data, @NonNull ModuleLog L) {
         assert data != null;
 
-        boolean removed = false;
+        StringBuilder removedKeys = new StringBuilder();
 
         for (Iterator<Map.Entry<String, Object>> it = data.entrySet().iterator(); it.hasNext(); ) {
             Map.Entry<String, Object> entry = it.next();
@@ -305,15 +305,16 @@ static boolean removeUnsupportedDataTypes(@NonNull Map<String, Object> data) {
             if (key == null || key.isEmpty() || !(isSupportedDataType(value))) {
                 //found unsupported data type or null key or value, removing
                 it.remove();
-                removed = true;
+                removedKeys.append("key:[").append(key).append("] value:[").append(value).append("] ").append("type: [").append(value == null ? "null" : value.getClass().getSimpleName()).append("] ,");
             }
         }
+        String removedKeysStr = removedKeys.toString();
 
-        if (removed) {
-            Countly.sharedInstance().L.w("[Utils] Unsupported data types were removed from provided segmentation");
+        if (!removedKeysStr.isEmpty()) {
+            L.w("[UtilsInternalLimits] removeUnsupportedDataTypes, removed " + removedKeysStr + " from the provided data map.");
         }
 
-        return removed;
+        return !removedKeysStr.isEmpty();
     }
 
     /**