Skip to content

Commit f4bbe2b

Browse files
authored
Merge pull request #372 from Countly/android24_7_1
fix: hot for orientation tests
2 parents 3c62f8b + 8491b57 commit f4bbe2b

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

sdk/src/androidTest/java/ly/count/android/sdk/TestUtils.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,14 @@ protected static CountlyStore getCountyStore() {
512512
return resultMapArray;
513513
}
514514

515+
protected static void removeRequestContains(String search) {
516+
for (String request : getCountyStore().getRequests()) {
517+
if (request.contains(search)) {
518+
getCountyStore().removeRequest(request);
519+
}
520+
}
521+
}
522+
515523
protected static Map<String, Object> map(Object... args) {
516524
Map<String, Object> map = new ConcurrentHashMap<>();
517525

sdk/src/androidTest/java/ly/count/android/sdk/scSE_SessionsTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,12 @@ public void SE_201_CNR_M() throws InterruptedException {
9797

9898
flowManualSessions(countly);
9999

100-
Assert.assertEquals(5, TestUtils.getCurrentRQ().length);
100+
TestUtils.removeRequestContains("orientation"); //TODO fix for now, tweak this
101+
Assert.assertEquals(4, TestUtils.getCurrentRQ().length);
101102
validateSessionBeginRequest(0, TestUtils.commonDeviceId);
103+
validateSessionUpdateRequest(1, 2, TestUtils.commonDeviceId);
102104
validateSessionUpdateRequest(2, 2, TestUtils.commonDeviceId);
103-
validateSessionUpdateRequest(3, 2, TestUtils.commonDeviceId);
104-
validateSessionEndRequest(4, 2, TestUtils.commonDeviceId);
105+
validateSessionEndRequest(3, 2, TestUtils.commonDeviceId);
105106
}
106107

107108
/**
@@ -213,7 +214,8 @@ public void SE_204_CNR_A_id_change() throws InterruptedException {
213214

214215
Assert.assertEquals(16, TestUtils.getCurrentRQ().length);
215216
validateSessionBeginRequest(0, TestUtils.commonDeviceId);
216-
TestUtils.validateRequest("newID", TestUtils.map("old_device_id", TestUtils.commonDeviceId), 1);
217+
boolean isOrientationRequest = TestUtils.getCurrentRQ()[1].containsKey("events");
218+
TestUtils.validateRequest("newID", TestUtils.map("old_device_id", TestUtils.commonDeviceId), isOrientationRequest ? 2 : 1);
217219
// orientation request
218220
validateSessionEndRequest(3, 2, "newID");
219221

0 commit comments

Comments
 (0)