Memory Leak since 26.1.1 / 26.1.2

[almozavr]

Context

Simple single activity app

Action

Rotation the screen

Issue

Leak Canary alert

┬───
│ GC Root: Thread object
│
├─ android.net.ConnectivityThread instance
│    Leaking: NO (PathClassLoader↓ is not leaking)
│    Thread name: 'ConnectivityThread'
│    ↓ Thread.contextClassLoader
├─ dalvik.system.PathClassLoader instance
│    Leaking: NO (Countly$SingletonHolder↓ is not leaking and A ClassLoader is
│    never leaking)
│    ↓ ClassLoader.runtimeInternalObjects
├─ java.lang.Object[] array
│    Leaking: NO (Countly$SingletonHolder↓ is not leaking)
│    ↓ Object[1449]
├─ ly.count.android.sdk.Countly$SingletonHolder class
│    Leaking: NO (a class is never leaking)
│    ↓ static Countly$SingletonHolder.instance
│                                     ~~~~~~~~
├─ ly.count.android.sdk.Countly instance
│    Leaking: UNKNOWN
│    Retaining 178,9 kB in 2039 objects
│    context_ instance of com.sample.App
│    ↓ Countly.moduleContent
│              ~~~~~~~~~~~~~
├─ ly.count.android.sdk.ModuleContent instance
│    Leaking: UNKNOWN
│    Retaining 127 B in 3 objects
│    currentActivity instance of leakcanary.internal.activity.LeakActivity with
│    mDestroyed = true
│    ↓ ModuleContent.currentActivity
│                    ~~~~~~~~~~~~~~~
╰→ leakcanary.internal.activity.LeakActivity instance
     Leaking: YES (ObjectWatcher was watching this because leakcanary.internal.
     activity.LeakActivity received Activity#onDestroy() callback and
     Activity#mDestroyed is true)

[arifBurakDemiray]

Hi @almozavr

Thanks for the report. We will deep dive this and will follow up here with the results.

[arifBurakDemiray]

Hi @almozavr

Thanks again for the report. We reproduced the leak on our side using LeakCanary on a multi-activity demo. Confirmed it triggers when an activity that opened the content zone is destroyed (rotation, navigation, finish) while the content overlay is still alive, the overlay's view context permanently retains that activity through Android's Application.ActivityLifecycleCallbacks list. The fix will land in the next minor release. Will follow up here with the PR shortly.

[arifBurakDemiray]

Hello again @almozavr 🙌

Here is the fix PR #557. It also contains some regression tests.

It will be released with next minor.

[almozavr]

Thanks, guys, it is amazingly quickly!