Fix macOS building issues (#92)

* - build issue fixed on macos
- used make_unique new api in c++14

* updated method signature

Co-authored-by: Zahid Zafar <>

Author: ZahidZafar

.gitignore

@@ -19,3 +19,4 @@ install_manifest.txt
 compile_commands.json
 CTestTestfile.cmake
 _deps
+cmake-build-debug/

include/countly.hpp

@@ -217,12 +217,12 @@ class Countly : public cly::CountlyDelegates {
    * Helper methods to fetch remote config from the server.
    */
 #pragma region Remote_Config_Helper_Methods
-  void _fetchRemoteConfig(std::map<std::string, std::string> &data);
-  void _updateRemoteConfigWithSpecificValues(std::map<std::string, std::string> &data);
+  void _fetchRemoteConfig(const std::map<std::string, std::string> &data);
+  void _updateRemoteConfigWithSpecificValues(const std::map<std::string, std::string> &data);
 #pragma endregion Remote_Config_Helper_Methods
 
   void processRequestQueue();
-  void addToRequestQueue(std::string &data);
+  void addToRequestQueue(const std::string &data);
   HTTPResponse sendHTTP(std::string path, std::string data);
 
   void _changeDeviceIdWithMerge(const std::string &value);

src/countly.cpp

@@ -839,7 +839,7 @@ void Countly::processRequestQueue() {
   mutex.unlock();
 }
 
-void Countly::addToRequestQueue(std::string &data) {
+void Countly::addToRequestQueue(const std::string &data) {
   if (request_queue.size() >= 1000) {
     log(Countly::LogLevel::WARNING, "[Countly][addToRequestQueue] Request Queue is full. Dropping the oldest request.");
     request_queue.pop_front();
@@ -1063,7 +1063,7 @@ void Countly::enableRemoteConfig() {
   mutex.unlock();
 }
 
-void Countly::_fetchRemoteConfig(std::map<std::string, std::string> &data) {
+void Countly::_fetchRemoteConfig(const std::map<std::string, std::string> &data) {
   HTTPResponse response = sendHTTP("/o/sdk", serializeForm(data));
   mutex.lock();
   if (response.success) {
@@ -1095,7 +1095,7 @@ nlohmann::json Countly::getRemoteConfigValue(const std::string &key) {
   return value;
 }
 
-void Countly::_updateRemoteConfigWithSpecificValues(std::map<std::string, std::string> &data) {
+void Countly::_updateRemoteConfigWithSpecificValues(const std::map<std::string, std::string> &data) {
   HTTPResponse response = sendHTTP("/o/sdk", serializeForm(data));
   mutex.lock();
   if (response.success) {

src/logger_module.cpp

@@ -1,13 +1,14 @@
 #include "countly/logger_module.hpp"
 #include <iostream>
+#include <memory>
 namespace cly {
 class LoggerModule::LoggerModuleImpl {
 public:
-  LoggerModuleImpl::LoggerModuleImpl() {}
+  LoggerModuleImpl() {}
   LoggerFunction logger_function;
 };
 
-LoggerModule::LoggerModule() { impl.reset(new LoggerModuleImpl()); }
+LoggerModule::LoggerModule() { impl = std::make_unique<LoggerModuleImpl>(); }
 
 LoggerModule::~LoggerModule() {}