Skip to content

Commit 628b545

Browse files
Merge pull request #43 from Countly/sdk-660
[SDK 660] Event segmentation issue fixed!
2 parents 090a931 + aa903d7 commit 628b545

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
21.11.1
2+
* !! Major breaking change !! Fixed a bug that triggered when providing segmentation to the "RecordEvent" call. Previously, by mistake, every segmentation value was parsed as a JSON and threw an exception when it wasn't a valid JSON string. Now this will not be the case and every String value can be provided. This is marked as a "major breaking change" in case some integrations were adding workarounds to this issue.
23
* ! Minor breaking change ! Default automatic session update duration changed to 60 seconds.
34
* Added a call to change the automatic session update duration.
45
* Fixed a bug where session duration was reported wrong.

include/countly.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ class Countly {
182182
Event event(key, count);
183183

184184
for (auto key_value: segmentation) {
185-
event.addSegmentation(key_value.first, json::parse(key_value.second));
185+
event.addSegmentation(key_value.first, key_value.second);
186186
}
187187

188188
addEvent(event);
@@ -192,7 +192,7 @@ class Countly {
192192
Event event(key, count, sum);
193193

194194
for (auto key_value: segmentation) {
195-
event.addSegmentation(key_value.first, json::parse(key_value.second));
195+
event.addSegmentation(key_value.first, key_value.second);
196196
}
197197

198198
addEvent(event);
@@ -202,7 +202,7 @@ class Countly {
202202
Event event(key, count, sum, duration);
203203

204204
for (auto key_value: segmentation) {
205-
event.addSegmentation(key_value.first, json::parse(key_value.second));
205+
event.addSegmentation(key_value.first, key_value.second);
206206
}
207207

208208
addEvent(event);

0 commit comments

Comments
 (0)