Tests refactors (#115)

* python scripts now creates new logs each time

* Moved a thing

* 2 more scenarios

* storage_db

* sqlite free invalid pointer changes

* error msg and changelog

* 104,19 and workflow

* added pr builds

* compiler

* iter

* added curl

* added submodules

* update submodules

* version

* ubuntu 20.04

* cnt on ett

* platforms yml

* fixed windows

* bnmae change

* tests

---------

Co-authored-by: ArtursK <[email protected]>

Author: turtledreams

.github/workflows/tests.yml

@@ -0,0 +1,62 @@
+name: Run Tests
+
+on:
+  push:
+    branches: [master, staging]
+  pull_request:
+    branches: [master, staging]
+
+jobs:
+  doctests:
+    runs-on: ${{ matrix.os }}
+    timeout-minutes: 120
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu-20.04
+          - macos-11.0
+          - windows-2019
+
+        include:
+          - os: windows-2019
+            cmake-generator: -G "Visual Studio 16 2019" -A x64
+            cmake-install: "choco install -y cmake"
+            dependencies: |
+              choco install -y openssl
+              choco install -y visualstudio2017-workload-vctools
+              choco upgrade -y visualstudio2017-workload-vctools
+            make: msbuild  countly-tests.vcxproj -t:rebuild -verbosity:diag -property:Configuration=Release && .\Release\countly-tests.exe
+          - os: macos-11.0
+            cmake-install: "brew install cmake"
+            dependencies: "brew install openssl"
+            make: make ./countly-tests && ./countly-tests
+          - os: ubuntu-20.04
+            cmake-install: "sudo apt-get update && sudo apt-get install -y cmake"
+            dependencies: "sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev"
+            make: make ./countly-tests && ./countly-tests
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+        with:
+          submodules: "recursive"
+
+      - name: Update submodules
+        run: git submodule update --init --recursive
+
+      - name: Install CMake
+        run: ${{ matrix.cmake-install }}
+
+      - name: Install dependencies
+        run: ${{ matrix.dependencies }}
+
+      - name: Set up MSVC
+        if: matrix.os == 'windows-2019'
+        uses: microsoft/setup-msbuild@v1
+
+      - name: Build and run tests
+        run: |
+          cmake -DCOUNTLY_BUILD_TESTS=1 -B build . ${{ matrix.cmake-generator }}
+          cd build
+          ${{ matrix.make }}

CHANGELOG.md

@@ -1,42 +1,45 @@
-22.09.0
+## 22.09.1
+* Mitigated a problem that caused invalid pointer error if the database path was set wrong 
+
+## 22.09.0
 * ! Minor breaking change ! SDK configuration now can't be changed after initialization/start
 * Added a persistent requests queue when building the SDK with the 'COUNTLY_USE_SQLITE' flag
 * Fixed a bug where view's name was being overriden by segmentation provided.
 
-22.06.4
+## 22.06.4
 * Fixed a bug where the SDK 'mutex' was being locked twice when built with the 'COUNTLY_USE_SQLITE' flag.
 
-22.06.3
+## 22.06.3
 * Fixed a bug where empty metrics were sent with session begin request.
 
-22.06.2
+## 22.06.2
 * Fixed a bug where metrics were not sent with session begin request.
 
-22.06.1
+## 22.06.1
 * !! Major breaking change !! We are removing the 'LogLevel' enum out of the 'Countly' class which will change how that enum can be referenced. 'Countly::LogLevel' will not work, you will have to use 'cly::LogLevel' instead.
 * Added functionality to record crash.
 * Added ability to record breadcrumbs for crash recording.
 
-22.06.0
+## 22.06.0
 * !! Major breaking change !! We are adding the 'cly' namespace on 'Countly' class which will change how that class can be referenced. 'Countly::' will not work, you will have to use 'cly::Countly::' instead.
 * !! Major breaking change !! We are extracting the 'Event' class out of the 'Countly' class which will change how that class can be referenced. 'Countly::Event' will not work, you will have to use 'cly::Event' instead.
 * !! Major breaking change !! Increased the compiler version required to compile the SDK. It's increased from version C++11 to C++14.
 * Making network requests has been reworked. They will now be sent on a separate thread. Requests will also be added in an internal queue and will be sent one at a time.
 * When making network requests, the SDK will now unlock it's mutex.
 * Fixed a bug that caused an exception on windows when encoding data that contains special characters. 
 
-22.02.0
+## 22.02.0
 * Added 10-second time-outs for all windows HTTP transactions.
 * Added ability to record views.
 
-21.11.3
+## 21.11.3
 * Added functionality to set custom SHA256.
 
-21.11.2
+## 21.11.2
 * Fixed a bug that occurred after trying to erase events from the SQLite database when there were none.
 * Fixed a bug with the checksum calculation.
 
-21.11.1
+## 21.11.1
 * !! Major breaking change !! Fixed a bug that triggered when providing segmentation to the "RecordEvent" call. Previously, by mistake, every segmentation value was parsed as a JSON and threw an exception when it wasn't a valid JSON string. 
 Now this will not be the case and every String value can be provided. This is marked as a "major breaking change" in case some integrations were adding workarounds to this issue.
 * ! Minor breaking change ! Default automatic session update duration changed to 60 seconds.
@@ -52,7 +55,7 @@ Now this will not be the case and every String value can be provided. This is ma
 * Fixed issues with location requests.
 * Deprecated old location calls and introduced a new location call
 
-21.11.0
+## 21.11.0
 * Fixed session duration issue.
 * Added functionality to report event duration manually.
 * 'startOnCloud' in 'Countly' is deprecated and this is going to be removed in the future.

CMakeLists.txt

@@ -108,11 +108,13 @@ if(COUNTLY_BUILD_TESTS)
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/views.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/session.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/storage.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/tests/storage_db.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/event.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/crash.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/request.cpp
     ${CMAKE_CURRENT_SOURCE_DIR}/tests/config.cpp)
-
+    
+    target_compile_options(countly-tests PRIVATE -g)
     target_compile_definitions(countly-tests PRIVATE COUNTLY_BUILD_TESTS)
   if(COUNTLY_USE_SQLITE)
     message("Compiling definitions for sqlite")

include/countly.hpp

@@ -33,7 +33,7 @@ class Countly : public cly::CountlyDelegates {
 public:
   Countly();
 
-  ~Countly();
+  virtual ~Countly();
 
   // Returns the singleton instance of Countly
   static Countly &getInstance();
@@ -131,8 +131,6 @@ class Countly : public cly::CountlyDelegates {
   void SetPath(const std::string &path) {
 #ifdef COUNTLY_USE_SQLITE
     setDatabasePath(path);
-#elif defined _WIN32
-    UNREFERENCED_PARAMETER(path);
 #endif
   }
 

python_build_script.py

@@ -4,7 +4,9 @@
 import itertools
 
 # Set up logging
-logging.basicConfig(filename='test_results.log', level=logging.INFO, format='%(asctime)s:%(levelname)s:%(message)s')
+log_filename = 'test_results_{}.log'.format(datetime.datetime.now().strftime('%Y%m%d_%H%M%S'))
+logging.basicConfig(filename=log_filename, level=logging.INFO, format='%(asctime)s:%(levelname)s:%(message)s')
+
 # List all combinations of COUNTLY_USE_CUSTOM_SHA256 and COUNTLY_USE_SQLITE
 options = [(0, 0), (0, 1), (1, 0), (1, 1)]