Merge pull request #28 from Countly/sdk-652

[SDK 652] Duration and event bug fixed while updating session.

Author: ArtursKadikis

CHANGELOG.md

@@ -1,3 +1,8 @@
+21.11.1
+* ! Minor breaking change ! Default automatic session update duration changed to 60 seconds.
+* Added a call to change the automatic session update duration.
+* Fixed a bug where session duration was reported wrong.
+
 21.11.0
 * Fixed session duration issue.
 * Added functionality to report event duration manually.

examples/example_integration.cpp

@@ -93,8 +93,8 @@ int main() {
 		}
 	}
 
-	ct.updateSession();
-	ct.stop();
+	//ct.updateSession();
+	ct.endSession();
 
 	return 0;
 }

include/countly.hpp

@@ -207,6 +207,11 @@ class Countly {
 
 		addEvent(event);
 	}
+
+	/* Provide 'updateInterval' in seconds. */
+	inline void setAutomaticSessionUpdateInterval(unsigned short updateInterval) {
+		_auto_session_update_interval = updateInterval;
+	}
 private:
 	void log(LogLevel level, const std::string& message);
 
@@ -225,7 +230,7 @@ class Countly {
 	int port;
 	bool use_https;
 	bool always_use_post;
-	std::chrono::system_clock::time_point last_sent;
+	std::chrono::system_clock::time_point last_sent_session_request;
 	bool began_session;
 
 	json session_params;
@@ -236,6 +241,7 @@ class Countly {
 	bool stop_thread;
 	bool running;
 	size_t wait_milliseconds;
+	unsigned short _auto_session_update_interval = 60; // value is in seconds;
 
 	size_t max_events;
 #ifndef COUNTLY_USE_SQLITE

src/countly.cpp

@@ -202,19 +202,21 @@ void Countly::start(const std::string& app_key, const std::string& host, int por
 	}
 
 	if (!running) {
+
+		mutex.unlock();
+		beginSession();
+		mutex.lock();
+
 		if (start_thread) {
 			stop_thread = false;
+
 			try {
 				thread = new std::thread(&Countly::updateLoop, this);
 			} catch(const std::system_error& e) {
 				std::ostringstream log_message;
 				log_message << "Could not create thread: " << e.what();
 				log(Countly::LogLevel::FATAL, log_message.str());
 			}
-		} else {
-			mutex.unlock();
-			beginSession();
-			mutex.lock();
 		}
 	}
 	mutex.unlock();
@@ -400,7 +402,7 @@ bool Countly::beginSession() {
 	}
 
 	if (sendHTTP("/i", Countly::serializeForm(data)).success) {
-		last_sent = Countly::getTimestamp();
+		last_sent_session_request = Countly::getTimestamp();
 		began_session = true;
 	}
 
@@ -415,8 +417,6 @@ bool Countly::beginSession() {
 }
 
 bool Countly::updateSession() {
-	log(Countly::LogLevel::INFO, "[Countly][updateSession]");
-
 	mutex.lock();
 	if (!began_session) {
 		mutex.unlock();
@@ -484,39 +484,35 @@ bool Countly::updateSession() {
 	auto duration = std::chrono::duration_cast<std::chrono::seconds>(getSessionDuration());
 	mutex.lock();
 
-	if (no_events) {
-		if (duration.count() > COUNTLY_KEEPALIVE_INTERVAL) {
-			std::map<std::string, std::string> data = {
-				{"app_key", session_params["app_key"].get<std::string>()},
-				{"device_id", session_params["device_id"].get<std::string>()},
-				{"session_duration", std::to_string(duration.count())}
-			};
-			if (!sendHTTP("/i", Countly::serializeForm(data)).success) {
-				mutex.unlock();
-				return false;
-			}
-
-			last_sent += duration;
+	if (duration.count() >= _auto_session_update_interval) {
+		log(Countly::LogLevel::DEBUG, "[Countly][updateSession] sending session update.");
+		std::map<std::string, std::string> data = {
+			{"app_key", session_params["app_key"].get<std::string>()},
+			{"device_id", session_params["device_id"].get<std::string>()},
+			{"session_duration", std::to_string(duration.count())}
+		};
+		if (!sendHTTP("/i", Countly::serializeForm(data)).success) {
+			mutex.unlock();
+			return false;
 		}
 
-		mutex.unlock();
-		return true;
+		last_sent_session_request += duration;
 	}
 
-	std::map<std::string, std::string> data = {
+	if (!no_events) {
+		log(Countly::LogLevel::DEBUG, "[Countly][updateSession] sending event.");
+		std::map<std::string, std::string> data = {
 		{"app_key", session_params["app_key"].get<std::string>()},
 		{"device_id", session_params["device_id"].get<std::string>()},
-		{"session_duration", std::to_string(duration.count())},
 		{"events", events.dump()}
-	};
+		};
 
-	if (!sendHTTP("/i", Countly::serializeForm(data)).success) {
-		mutex.unlock();
-		return false;
+		if (!sendHTTP("/i", Countly::serializeForm(data)).success) {
+			mutex.unlock();
+			return false;
+		}
 	}
 
-	last_sent += duration;
-
 #ifndef COUNTLY_USE_SQLITE
 	event_queue.clear();
 #else
@@ -554,7 +550,7 @@ bool Countly::endSession() {
 		{"end_session", "1"}
 	};
 	if (sendHTTP("/i", Countly::serializeForm(data)).success) {
-		last_sent = now;
+		last_sent_session_request = now;
 		began_session = false;
 		mutex.unlock();
 		return true;
@@ -804,7 +800,7 @@ log(Countly::LogLevel::DEBUG, "[Countly][sendHTTP] data: "+ data);
 
 std::chrono::system_clock::duration Countly::getSessionDuration(std::chrono::system_clock::time_point now) {
 	mutex.lock();
-	std::chrono::system_clock::duration duration = now - last_sent;
+	std::chrono::system_clock::duration duration = now - last_sent_session_request;
 	mutex.unlock();
 	return duration;
 }
@@ -827,8 +823,8 @@ void Countly::updateLoop() {
 		}
 		size_t last_wait_milliseconds = wait_milliseconds;
 		mutex.unlock();
-		updateSession();
 		std::this_thread::sleep_for(std::chrono::milliseconds(last_wait_milliseconds));
+		updateSession();
 	}
 	mutex.lock();
 	running = false;