[SDK 669] Fixed bug in deleting events locally (#49)

* Fix no event printing error

* change log and sdk version updated

* change log updated and sdk version

* cpp-codeql

* removed code analysis

* Adding a comment

* Update CHANGELOG.md

Co-authored-by: ArtursKadikis <[email protected]>

Author: ZahidZafar

CHANGELOG.md

@@ -1,3 +1,6 @@
+21.11.2
+* Fixed a bug that occured after trying to erase events from the sqlite database when there were none.
+
 21.11.1
 * !! Major breaking change !! Fixed a bug that triggered when providing segmentation to the "RecordEvent" call. Previously, by mistake, every segmentation value was parsed as a JSON and threw an exception when it wasn't a valid JSON string. Now this will not be the case and every String value can be provided. This is marked as a "major breaking change" in case some integrations were adding workarounds to this issue.
 * ! Minor breaking change ! Default automatic session update duration changed to 60 seconds.

include/countly.hpp

@@ -21,7 +21,7 @@ using json = nlohmann::json;
 
 #define COUNTLY_SDK_NAME "cpp-native-unknown"
 #define COUNTLY_SDK_VERSION "0.1.0"
-#define COUNTLY_API_VERSION "21.11.1"
+#define COUNTLY_API_VERSION "21.11.2"
 #define COUNTLY_POST_THRESHOLD 2000
 #define COUNTLY_KEEPALIVE_INTERVAL 3000
 #define COUNTLY_MAX_EVENTS_DEFAULT 200

src/countly.cpp

@@ -685,19 +685,22 @@ bool Countly::updateSession() {
 #ifndef COUNTLY_USE_SQLITE
 	event_queue.clear();
 #else
-	return_value = sqlite3_open(database_path.c_str(), &database);
-	if (return_value == SQLITE_OK) {
-		std::ostringstream sql_statement_stream;
-		sql_statement_stream << "DELETE FROM events WHERE evtid IN " << event_ids << ';';
-		std::string sql_statement = sql_statement_stream.str();
+	if (!event_ids.empty()) {
+		//we attempt to clear the events in the database only if there were any events collected previously
+		return_value = sqlite3_open(database_path.c_str(), &database);
+		if (return_value == SQLITE_OK) {
+			std::ostringstream sql_statement_stream;
+			sql_statement_stream << "DELETE FROM events WHERE evtid IN " << event_ids << ';';
+			std::string sql_statement = sql_statement_stream.str();
 
-		return_value = sqlite3_exec(database, sql_statement.c_str(), nullptr, nullptr, &error_message);
-		if (return_value != SQLITE_OK) {
-			log(Countly::LogLevel::ERROR, error_message);
-			sqlite3_free(error_message);
+			return_value = sqlite3_exec(database, sql_statement.c_str(), nullptr, nullptr, &error_message);
+			if (return_value != SQLITE_OK) {
+				log(Countly::LogLevel::ERROR, error_message);
+				sqlite3_free(error_message);
+			}
 		}
+		sqlite3_close(database);
 	}
-	sqlite3_close(database);
 #endif
 
 	mutex.unlock();