Merge pull request #394 from Countly/disable_sc

feat: disable sc calls

Author: turtledreams

CHANGELOG.md

@@ -1,7 +1,7 @@
 ## XX.XX.XX
 * Adding SDK health check requests after init
 * The feedback widgets now have fullscreen and transparent backgrounds for a cleaner look.
-* Added a config method to disable server config in the initialization "disableSDKBehaviorSettings()".
+* Added a config method to disable server config in the initialization "disableSDKBehaviorSettingsUpdates()".
 
 ## 25.4.1
 * Mitigated an issue that could occur while serializing events to improve stability, performance and memory usage.

Countly.m

@@ -92,7 +92,7 @@ - (void)startWithConfig:(CountlyConfig *)config
 
     config = [self checkAndFixInternalLimitsConfig:config];
 
-    if (config.disableSDKBehaviorSettings) {
+    if (config.disableSDKBehaviorSettingsUpdates) {
         [CountlyServerConfig.sharedInstance disableSDKBehaviourSettings];
     }
     [CountlyServerConfig.sharedInstance retrieveServerConfigFromStorage:config.sdkBehaviorSettings];
@@ -170,7 +170,7 @@ - (void)startWithConfig:(CountlyConfig *)config
     CountlyDeviceInfo.sharedInstance.customMetrics = [customMetricsTruncated cly_limited:@"Custom metric"];
 
     [Countly.user save];
-  // If something added related to server config, make sure to check CountlyServerConfig.notifySdkConfigChange
+    // If something added related to server config, make sure to check CountlyServerConfig.notifySdkConfigChange
     [CountlyServerConfig.sharedInstance fetchServerConfig:config];
 
 #if (TARGET_OS_IOS)

CountlyConfig.h

@@ -676,9 +676,9 @@ typedef enum : NSUInteger
 @property(nonatomic, copy) NSString *sdkBehaviorSettings;
 
 /**
- * Disable the server configuration
+ * Disable the server configuration updates to the server
  */
-@property(nonatomic) BOOL disableSDKBehaviorSettings;
+@property(nonatomic) BOOL disableSDKBehaviorSettingsUpdates;
 
 #if (TARGET_OS_IOS)
 /**

CountlyServerConfig.m

@@ -38,7 +38,7 @@ @interface CountlyServerConfig () {
 @property (nonatomic) NSInteger version;
 @property (nonatomic) long long timestamp;
 @property (nonatomic) long long lastFetchTimestamp;
-@property (nonatomic) BOOL serverConfigDisabled;
+@property (nonatomic) BOOL serverConfigUpdatesDisabled;
 
 @end
 
@@ -109,16 +109,13 @@ - (instancetype)init
         _version = 0;
         _currentServerConfigUpdateInterval = 4;
         _requestTimer = nil;
-        _serverConfigDisabled = NO;
+        _serverConfigUpdatesDisabled = NO;
     }
     return self;
 }
 
 - (void)retrieveServerConfigFromStorage:(NSString *)sdkBehaviorSettings
 {
-    if (_serverConfigDisabled) {
-        return;
-    }
     NSError *error = nil;
     NSDictionary *serverConfigObject = [CountlyPersistency.sharedInstance retrieveServerConfig];
     if (serverConfigObject.count == 0 && sdkBehaviorSettings)
@@ -202,10 +199,6 @@ - (void)populateServerConfig:(NSDictionary *)serverConfig
 
 - (void)notifySdkConfigChange:(CountlyConfig *)config
 {
-    if (_serverConfigDisabled) {
-        return;
-    }
-    
     config.enableDebug = _loggingEnabled || config.enableDebug;
     CountlyCommon.sharedInstance.enableDebug = config.enableDebug;
 
@@ -306,7 +299,7 @@ - (void)fetchServerConfigTimer:(NSTimer *)timer
 
 - (void)fetchServerConfigIfTimeIsUp
 {
-    if (_serverConfigDisabled) {
+    if (_serverConfigUpdatesDisabled) {
         return;
     }
 
@@ -324,10 +317,12 @@ - (void)fetchServerConfigIfTimeIsUp
 
 - (void)fetchServerConfig:(CountlyConfig *)config
 {
-    if (_serverConfigDisabled) {
+    CLY_LOG_D(@"%s, fetching sdk behavior settings", __FUNCTION__);
+    
+    if (_serverConfigUpdatesDisabled) {
+        CLY_LOG_D(@"%s, sdk behavior settings updates disabled, omitting fetch", __FUNCTION__);
         return;
     }
-    CLY_LOG_D(@"Fetching server configs...");
 
     if (CountlyDeviceInfo.sharedInstance.isDeviceIDTemporary)
         return;
@@ -417,7 +412,7 @@ - (NSURLRequest *)serverConfigRequest
 }
 
 - (void)disableSDKBehaviourSettings {
-    _serverConfigDisabled = YES;
+    _serverConfigUpdatesDisabled = YES;
 }
 
 - (BOOL)trackingEnabled