Skip to content

Commit e1a26bc

Browse files
[Java] fix question mark issue when getting available feedback widget list (#168)
* fix: change location of question mark * fix: feedback widget qmark * Update CHANGELOG.md --------- Co-authored-by: Artūrs Kadiķis <[email protected]>
1 parent 1a9d5e7 commit e1a26bc

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 23.10.1
2+
3+
* Fixed a bug where getting the feedback widget list would fail if "salt" was enabled.
4+
15
## 23.10.0
26

37
* ! Minor breaking change ! Calling "init" twice will now not reinitialize the SDK. The call will be ignored

sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleFeedback.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ private void getAvailableFeedbackWidgetsInternal(CallbackOnFinish<List<CountlyFe
5959
String params = ModuleRequests.prepareRequiredParamsAsString(internalConfig, "method", "feedback");
6060
ImmediateRequestGenerator iRGenerator = internalConfig.immediateRequestGenerator;
6161

62-
iRGenerator.createImmediateRequestMaker().doWork("?" + params, "/o/sdk", transport, false, networkingIsEnabled, checkResponse -> {
62+
iRGenerator.createImmediateRequestMaker().doWork(params, "/o/sdk?", transport, false, networkingIsEnabled, checkResponse -> {
6363
if (checkResponse == null) {
6464
L.d("[ModuleFeedback] getAvailableFeedbackWidgetsInternal, Not possible to retrieve widget list. Probably due to lack of connection to the server");
6565
callback.onFinished(null, "Not possible to retrieve widget list. Probably due to lack of connection to the server");

sdk-java/src/test/java/ly/count/sdk/java/internal/ModuleFeedbackTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ public void getAvailableFeedbackWidgets_base(List<CountlyFeedbackWidget> expecte
197197
ImmediateRequestI requestMaker = (requestData, customEndpoint, cp, requestShouldBeDelayed, networkingIsEnabled, callback, log) -> {
198198
Map<String, String> params = TestUtils.parseQueryParams(requestData);
199199
Assert.assertEquals("feedback", params.get("method"));
200-
TestUtils.validateRequestMakerRequiredParams("/o/sdk", customEndpoint, requestShouldBeDelayed, networkingIsEnabled);
200+
TestUtils.validateRequestMakerRequiredParams("/o/sdk?", customEndpoint, requestShouldBeDelayed, networkingIsEnabled);
201201
TestUtils.validateRequiredParams(params);
202202
callback.callback(returnedResponse);
203203
};

0 commit comments

Comments
 (0)