[Sdk 368] Internal limits (#29)

* Events internal limits added

* Internal limits
Events,
Views
Crash,
Userdetail(in progress)

* Config methods fixed!

* - trimming methods updated
- trimming methods usage commented
- internal events configuration commented

* Passed limit to trimming utils methods

* commit reversed

* code format

* Logger class init logic updated!

* Fixed Log init unit test

* code revert

* fixed a bug,
unit test added

* Trimm segment unit test added

* Config internal limits properties commented

* Logger tweaks in tests

---------

Co-authored-by: Zahid Zafar <>
Co-authored-by: ArtursK <[email protected]>

Author: ZahidZafar

sdk-java/src/main/java/ly/count/sdk/java/Config.java

@@ -481,7 +481,93 @@ public boolean restore(byte[] data) {
      */
     protected int requestQueueMaxSize = 1000;
 
-    //endregion
+//    /**
+//    * Maximum size of all string keys
+//    */
+//    protected int maxKeyLength = 128;
+//
+//    /**
+//    * Maximum size of all values in our key-value pairs
+//    */
+//    protected int maxValueSize = 256;
+//
+//    /**
+//    * Max amount of custom (dev provided) segmentation in one event
+//    */
+//    protected int maxSegmentationValues = 30;
+//
+//    /**
+//    * Limits how many stack trace lines would be recorded per thread
+//    */
+//    protected int maxStackTraceLinesPerThread = 30;
+//
+//    /**
+//    * Limits how many characters are allowed per stack trace line
+//    */
+//    protected int maxStackTraceLineLength = 200;
+//
+//    /**
+//    * Set the maximum amount of breadcrumbs.
+//    */
+//    protected int totalBreadcrumbsAllowed = 100;
+//
+//    //endregion
+//
+//    public int getMaxKeyLength() {
+//        return maxKeyLength;
+//    }
+//
+//    public Config setMaxKeyLength(int maxKeyLength) {
+//        this.maxKeyLength = maxKeyLength;
+//        return this;
+//    }
+//
+//    public int getMaxValueSize() {
+//        return maxValueSize;
+//    }
+//
+//    public Config setMaxValueSize(int maxValueSize) {
+//        this.maxValueSize = maxValueSize;
+//        return this;
+//    }
+//
+//    public int getMaxSegmentationValues() {
+//        return maxSegmentationValues;
+//    }
+//
+//    public Config setMaxSegmentationValues(int maxSegmentationValues) {
+//        this.maxSegmentationValues = maxSegmentationValues;
+//        return this;
+//    }
+//
+//    public int getMaxStackTraceLinesPerThread() {
+//        return maxStackTraceLinesPerThread;
+//    }
+//
+//    public Config setMaxStackTraceLinesPerThread(int maxStackTraceLinesPerThread) {
+//        this.maxStackTraceLinesPerThread = maxStackTraceLinesPerThread;
+//        return this;
+//
+//    }
+//
+//    public int getMaxStackTraceLineLength() {
+//        return maxStackTraceLineLength;
+//    }
+//
+//    public Config setMaxStackTraceLineLength(int maxStackTraceLineLength) {
+//        this.maxStackTraceLineLength = maxStackTraceLineLength;
+//        return this;
+//    }
+//
+//    public int getTotalBreadcrumbsAllowed() {
+//        return totalBreadcrumbsAllowed;
+//    }
+//
+//    public Config setTotalBreadcrumbsAllowed(int totalBreadcrumbsAllowed) {
+//        this.totalBreadcrumbsAllowed = totalBreadcrumbsAllowed;
+//        return this;
+//
+//    }
 
 
     // TODO: storage limits & configuration

sdk-java/src/main/java/ly/count/sdk/java/Countly.java

@@ -79,7 +79,7 @@ else if (directory == null) {
             }
 
             InternalConfig internalConfig = new InternalConfig(config);
-            Log L = new Log(internalConfig);
+            Log L = new Log(internalConfig.loggingLevel, internalConfig.logListener);
             SDK sdk = new SDK();
             sdk.init(new CtxCore(sdk, internalConfig, L, directory), L);
 

sdk-java/src/main/java/ly/count/sdk/java/internal/EventImpl.java

@@ -1,5 +1,6 @@
 package ly.count.sdk.java.internal;
 
+import ly.count.sdk.java.Config;
 import org.json.JSONException;
 import org.json.JSONObject;
 
@@ -56,7 +57,7 @@ public interface EventRecorder {
 
     @Override
     public void record() {
-        if(SDKCore.instance != null && SDKCore.instance.config.isBackendModeEnabled()) {
+        if (SDKCore.instance != null && SDKCore.instance.config.isBackendModeEnabled()) {
             System.out.println("[EventImpl] record: Skipping event, backend mode is enabled!");
             return;
         }
@@ -71,7 +72,7 @@ public void record() {
 
     @Override
     public void endAndRecord() {
-        if(SDKCore.instance != null && SDKCore.instance.config.isBackendModeEnabled()) {
+        if (SDKCore.instance != null && SDKCore.instance.config.isBackendModeEnabled()) {
             System.out.println("[EventImpl] endAndRecord: Skipping event, backend mode is enabled!");
             return;
         }
@@ -190,7 +191,7 @@ public boolean equals(Object obj) {
         if (obj == null || !(obj instanceof EventImpl)) {
             return false;
         }
-        EventImpl event = (EventImpl)obj;
+        EventImpl event = (EventImpl) obj;
         if (timestamp != event.timestamp) {
             return false;
         }
@@ -223,6 +224,7 @@ public boolean equals(Object obj) {
 
     /**
      * Serialize to JSON format according to Countly server requirements
+     *
      * @return JSON string
      */
     public String toJSON() {
@@ -255,6 +257,7 @@ public String toJSON() {
 
     /**
      * Deserialize from JSON format according to Countly server requirements
+     *
      * @return JSON string
      */
     static EventImpl fromJSON(String jsonString, EventRecorder recorder) {

sdk-java/src/main/java/ly/count/sdk/java/internal/Log.java

@@ -8,14 +8,16 @@
  */
 
 public class Log {
-    LogCallback logListener = null;
-    private Config.LoggingLevel configLevel;
+    private final LogCallback logListener;
+    private final Config.LoggingLevel loggingLevel;
 
 
-    public Log(InternalConfig config) {
-        // let it be specific int and not index for visibility
-        configLevel = config.getLoggingLevel();
-        logListener = config.getLogListener();
+    public Log(Config.LoggingLevel loggingLevel, LogCallback logListener) {
+        if(loggingLevel == null) {
+            throw new NullPointerException("Logging level can't null.");
+        }
+        this.loggingLevel = loggingLevel;
+        this.logListener = logListener;
     }
 
     /**
@@ -69,7 +71,7 @@ public void v(String logMessage) {
     }
 
     private void print(String msg, Config.LoggingLevel level) {
-        if (level != null && configLevel.prints(level)) {
+        if (level != null && loggingLevel.prints(level)) {
             System.out.println(msg);
         }
     }

sdk-java/src/main/java/ly/count/sdk/java/internal/SessionImpl.java

@@ -20,12 +20,10 @@
 
 /**
  * This class represents session concept, that is one indivisible usage occasion of your application.
- *
  * Any data sent to Countly server is processed in a context of Session.
  * Only one session can send requests at a time, so even if you create 2 parallel sessions,
  * they will be made consequent automatically at the time of Countly SDK choice with no
  * correctness guarantees, so please avoid having parallel sessions.
- *
  */
 
 public class SessionImpl implements Session, Storable, EventImpl.EventRecorder {
@@ -97,7 +95,7 @@ public SessionImpl(CtxCore ctx, Long id) {
 
     @Override
     public Session begin() {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("[SessionImpl] begin: Skipping session begin, backend mode is enabled!");
             return this;
         }
@@ -136,7 +134,7 @@ Future<Boolean> begin(Long now) {
 
     @Override
     public Session update() {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("[SessionImpl] update: Skipping session update, backend mode is enabled!");
             return this;
         }
@@ -171,7 +169,7 @@ Future<Boolean> update(Long now) {
 
     @Override
     public void end() {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("end: Skipping session end, backend mode is enabled!");
             return;
         }
@@ -264,7 +262,7 @@ public boolean isActive() {
      *
      * @return calculated session duration to send in seconds
      */
-    private Long updateDuration(Long now){
+    private Long updateDuration(Long now) {
         now = now == null ? System.nanoTime() : now;
         Long duration;
 
@@ -285,7 +283,9 @@ public Event timedEvent(String key) {
         return timedEvents().event(ctx, key);
     }
 
-    protected TimedEvents timedEvents () { return SDKCore.instance.timedEvents(); }
+    protected TimedEvents timedEvents() {
+        return SDKCore.instance.timedEvents();
+    }
 
     @Override
     public void recordEvent(Event event) {
@@ -305,7 +305,7 @@ public void recordEvent(Event event) {
             }
 
             Config config = SDKCore.instance.config();
-            if (config != null && config.getEventsBufferSize() <= events.size()) {
+            if (config != null && ctx.getConfig().getEventsBufferSize() <= events.size()) {
                 update();
             }
         }
@@ -328,7 +328,7 @@ public Session addCrashReport(Throwable t, boolean fatal) {
 
     @Override
     public Session addCrashReport(Throwable t, boolean fatal, String name, Map<String, String> segments, String... logs) {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("[SessionImpl] addCrashReport: Skipping crash, backend mode is enabled!");
             return this;
         }
@@ -337,13 +337,15 @@ public Session addCrashReport(Throwable t, boolean fatal, String name, Map<Strin
             L.i("[SessionImpl] addCrashReport: Skipping event - feature is not enabled");
             return this;
         }
+
         SDKCore.instance.onCrash(ctx, t, fatal, name, segments, logs);
         return this;
     }
 
     @Override
     public Session addLocation(double latitude, double longitude) {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("[SessionImpl] addLocation: Skipping location, backend mode is enabled!");
             return this;
         }
@@ -353,7 +355,7 @@ public Session addLocation(double latitude, double longitude) {
             L.i("[SessionImpl] addLocation: Skipping event - feature is not enabled");
             return this;
         }
-        return addParam("location", latitude + "," + longitude);
+        return (Session) addParam("location", latitude + "," + longitude);
     }
 
     public View view(String name, boolean start) {
@@ -365,7 +367,9 @@ public View view(String name, boolean start) {
         if (currentView != null) {
             currentView.stop(false);
         }
+
         currentView = new ViewImpl(this, name, L);
+
         currentView.start(start);
         startView = false;
         return currentView;
@@ -401,7 +405,7 @@ public Usage resetDeviceId(String id) {
 
     @Override
     public Usage changeDeviceIdWithMerge(String id) {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("[SessionImpl] changeDeviceIdWithMerge: Skipping change device id with merge, backend mode is enabled!");
             return this;
         }
@@ -413,7 +417,7 @@ public Usage changeDeviceIdWithMerge(String id) {
 
     @Override
     public Usage changeDeviceIdWithoutMerge(String id) {
-        if(ctx.getConfig().isBackendModeEnabled()) {
+        if (ctx.getConfig().isBackendModeEnabled()) {
             L.w("[SessionImpl] changeDeviceIdWithoutMerge: Skipping change device id without merge, backend mode is enabled!");
             return this;
         }
@@ -573,7 +577,7 @@ public boolean equals(Object obj) {
             return false;
         }
 
-        SessionImpl session = (SessionImpl)obj;
+        SessionImpl session = (SessionImpl) obj;
         if (!id.equals(session.id)) {
             return false;
         }

sdk-java/src/main/java/ly/count/sdk/java/internal/UserEditorImpl.java

@@ -309,6 +309,7 @@ void perform(JSONObject changes, Set<String> cohortsAdded, Set<String> cohortsRe
         cohortsRemoved.addAll(cohortsToRemove);
     }
 
+
     @Override
     public UserEditor set(String key, Object value) {
         sets.put(key, value);