Skip to content

Commit 29d92c5

Browse files
widatamawidatama
committed
[remote-config] Update tests
1 parent 5592cfc commit 29d92c5

File tree

1 file changed

+67
-67
lines changed

1 file changed

+67
-67
lines changed

‎plugins/remote-config/tests/fetch_remote_config.js‎

Lines changed: 67 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const AMOUNT_OF_KEYS = 5;
1313
const PARAMETER_PREFIX = 'fetch_remote_config_param_';
1414
const CONDITION_PREFIX = 'fetchremoteconfigcond';
1515
const VALUE_PREFIX = 'value_';
16-
const TARGETTED_USER_ID = 'targetted_user';
16+
const TARGETED_USER_ID = 'targeted_user';
1717

1818
describe('Fetch remote config', () => {
1919
before(async() => {
@@ -136,7 +136,7 @@ describe('Fetch remote config', () => {
136136
}
137137
});
138138

139-
describe('Targetting', () => {
139+
describe('Targeting', () => {
140140
before(async() => {
141141
await request
142142
.post('/i/remote-config/add-condition')
@@ -147,8 +147,8 @@ describe('Fetch remote config', () => {
147147
condition: JSON.stringify({
148148
condition_name: `${CONDITION_PREFIX}0`,
149149
condition_color: 1,
150-
condition: { did: { $in: [TARGETTED_USER_ID] } },
151-
condition_definition: `ID = ${TARGETTED_USER_ID}`,
150+
condition: { did: { $in: [TARGETED_USER_ID] } },
151+
condition_definition: `ID = ${TARGETED_USER_ID}`,
152152
condition_description: '-',
153153
seed_value: '',
154154
}),
@@ -188,153 +188,153 @@ describe('Fetch remote config', () => {
188188
.expect('Content-Type', /json/);
189189
});
190190

191-
it('Should match targetted user (device id)', () => {
192-
const targettedUser = {
191+
it('Should match targeted user (device id)', () => {
192+
const targetedUser = {
193193
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
194194
uid: '13',
195-
did: 'targetted_user',
195+
did: 'targeted_user',
196196
};
197-
const query = { did: { $in: ['targetted_user'] } };
197+
const query = { did: { $in: ['targeted_user'] } };
198198

199-
should(remoteConfig.processFilter(targettedUser, query)).equal(true);
199+
should(remoteConfig.processFilter(targetedUser, query)).equal(true);
200200
});
201201

202-
it('Should not match non targetted user (device id)', () => {
203-
const nonTargettedUser = {
202+
it('Should not match non targeted user (device id)', () => {
203+
const nonTargetedUser = {
204204
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
205205
uid: '13',
206-
did: 'non_targetted_user',
206+
did: 'non_targeted_user',
207207
};
208-
const query = { did: { $in: ['targetted_user'] } };
208+
const query = { did: { $in: ['targeted_user'] } };
209209

210-
should(remoteConfig.processFilter(nonTargettedUser, query)).equal(false);
210+
should(remoteConfig.processFilter(nonTargetedUser, query)).equal(false);
211211
});
212212

213-
it('Should match targetted user (country)', () => {
214-
const targettedUser = {
213+
it('Should match targeted user (country)', () => {
214+
const targetedUser = {
215215
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
216216
uid: '13',
217-
did: 'targetted_user',
217+
did: 'targeted_user',
218218
cc: 'UK',
219219
};
220220
const query = { 'up.cc': { $exists: true } };
221221

222-
should(remoteConfig.processFilter(targettedUser, query)).equal(true);
222+
should(remoteConfig.processFilter(targetedUser, query)).equal(true);
223223
});
224224

225-
it('Should match targetted user (app version)', () => {
226-
const targettedUser = {
225+
it('Should match targeted user (app version)', () => {
226+
const targetedUser = {
227227
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
228228
uid: '13',
229-
did: 'targetted_user',
229+
did: 'targeted_user',
230230
av: '1:0:0',
231231
};
232232
const queryGt = { 'up.av': { $gt: '0:0:0' } };
233233
const queryGte = { 'up.av': { $gte: '1:0:0' } };
234234
const queryLt = { 'up.av': { $lt: '2:0:0' } };
235235
const queryLte = { 'up.av': { $lte: '1:0:0' } };
236236

237-
should(remoteConfig.processFilter(targettedUser, queryGt)).equal(true);
238-
should(remoteConfig.processFilter(targettedUser, queryGte)).equal(true);
239-
should(remoteConfig.processFilter(targettedUser, queryLt)).equal(true);
240-
should(remoteConfig.processFilter(targettedUser, queryLte)).equal(true);
237+
should(remoteConfig.processFilter(targetedUser, queryGt)).equal(true);
238+
should(remoteConfig.processFilter(targetedUser, queryGte)).equal(true);
239+
should(remoteConfig.processFilter(targetedUser, queryLt)).equal(true);
240+
should(remoteConfig.processFilter(targetedUser, queryLte)).equal(true);
241241
});
242242

243-
it('Should not match non targetted user (app version)', () => {
244-
const nonTargettedUser = {
243+
it('Should not match non targeted user (app version)', () => {
244+
const nonTargetedUser = {
245245
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
246246
uid: '13',
247-
did: 'targetted_user',
247+
did: 'targeted_user',
248248
av: '1:0:0',
249249
};
250250
const queryGt = { 'up.av': { $gt: '1:0:0' } };
251251
const queryGte = { 'up.av': { $gte: '2:0:0' } };
252252
const queryLt = { 'up.av': { $lt: '1:0:0' } };
253253
const queryLte = { 'up.av': { $lte: '0:0:0' } };
254254

255-
should(remoteConfig.processFilter(nonTargettedUser, queryGt)).equal(false);
256-
should(remoteConfig.processFilter(nonTargettedUser, queryGte)).equal(false);
257-
should(remoteConfig.processFilter(nonTargettedUser, queryLt)).equal(false);
258-
should(remoteConfig.processFilter(nonTargettedUser, queryLte)).equal(false);
255+
should(remoteConfig.processFilter(nonTargetedUser, queryGt)).equal(false);
256+
should(remoteConfig.processFilter(nonTargetedUser, queryGte)).equal(false);
257+
should(remoteConfig.processFilter(nonTargetedUser, queryLt)).equal(false);
258+
should(remoteConfig.processFilter(nonTargetedUser, queryLte)).equal(false);
259259
});
260260

261-
it('Should match targetted user ($and query)', () => {
262-
const targettedUser = {
261+
it('Should match targeted user ($and query)', () => {
262+
const targetedUser = {
263263
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
264264
uid: '13',
265-
did: 'targetted_user',
265+
did: 'targeted_user',
266266
cc: 'UK',
267267
};
268-
const query = { 'up.cc': { $exists: true }, did: { $in: ['targetted_user'] } };
268+
const query = { 'up.cc': { $exists: true }, did: { $in: ['targeted_user'] } };
269269
const altQuery = {
270270
$and: [
271271
{ 'up.cc': { $exists: true } },
272-
{ did: { $in: ['targetted_user'] } },
272+
{ did: { $in: ['targeted_user'] } },
273273
],
274274
};
275275

276-
should(remoteConfig.processFilter(targettedUser, query)).equal(true);
277-
should(remoteConfig.processFilter(targettedUser, altQuery)).equal(true);
276+
should(remoteConfig.processFilter(targetedUser, query)).equal(true);
277+
should(remoteConfig.processFilter(targetedUser, altQuery)).equal(true);
278278
});
279279

280-
it('Should not match targetted user ($and query)', () => {
281-
const targettedUser = {
280+
it('Should not match targeted user ($and query)', () => {
281+
const targetedUser = {
282282
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
283283
uid: '13',
284-
did: 'targetted_user',
284+
did: 'targeted_user',
285285
cc: 'UK',
286286
};
287-
const query = { 'up.cc': { $exists: true }, did: { $nin: ['targetted_user'] } };
287+
const query = { 'up.cc': { $exists: true }, did: { $nin: ['targeted_user'] } };
288288
const altQuery = {
289289
$and: [
290290
{ 'up.cc': { $exists: true } },
291-
{ did: { $nin: ['targetted_user'] } },
291+
{ did: { $nin: ['targeted_user'] } },
292292
],
293293
};
294294

295-
should(remoteConfig.processFilter(targettedUser, query)).equal(false);
296-
should(remoteConfig.processFilter(targettedUser, altQuery)).equal(false);
295+
should(remoteConfig.processFilter(targetedUser, query)).equal(false);
296+
should(remoteConfig.processFilter(targetedUser, altQuery)).equal(false);
297297
});
298298

299-
it('Should match targetted user ($or query)', () => {
300-
const targettedUser = {
299+
it('Should match targeted user ($or query)', () => {
300+
const targetedUser = {
301301
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
302302
uid: '13',
303-
did: 'targetted_user',
303+
did: 'targeted_user',
304304
cc: 'UK',
305305
};
306306
const query = {
307307
$or: [
308308
{ 'up.cc': { $exists: true }},
309-
{ did: { $nin: ['targetted_user'] } },
309+
{ did: { $nin: ['targeted_user'] } },
310310
],
311311
};
312312

313-
should(remoteConfig.processFilter(targettedUser, query)).equal(true);
313+
should(remoteConfig.processFilter(targetedUser, query)).equal(true);
314314
});
315315

316-
it('Should not match targetted user ($or query)', () => {
317-
const targettedUser = {
316+
it('Should not match targeted user ($or query)', () => {
317+
const targetedUser = {
318318
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
319319
uid: '13',
320-
did: 'targetted_user',
320+
did: 'targeted_user',
321321
cc: 'UK',
322322
};
323323
const query = {
324324
$or: [
325325
{ 'up.cc': { $exists: false }},
326-
{ did: { $nin: ['targetted_user'] } },
326+
{ did: { $nin: ['targeted_user'] } },
327327
],
328328
};
329329

330-
should(remoteConfig.processFilter(targettedUser, query)).equal(false);
330+
should(remoteConfig.processFilter(targetedUser, query)).equal(false);
331331
});
332332

333-
it('Should match targetted user (combination query)', () => {
334-
const targettedUser = {
333+
it('Should match targeted user (combination query)', () => {
334+
const targetedUser = {
335335
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
336336
uid: '13',
337-
did: 'targetted_user',
337+
did: 'targeted_user',
338338
cc: 'UK',
339339
chr: {
340340
'chr_id': {
@@ -346,18 +346,18 @@ describe('Fetch remote config', () => {
346346
const query = {
347347
$or: [
348348
{ 'up.cc': { $in: ['UK'] }, chr: { $in: ['chr_id'] } },
349-
{ did: { $nin: ['targetted_user'] } },
349+
{ did: { $nin: ['targeted_user'] } },
350350
],
351351
};
352352

353-
should(remoteConfig.processFilter(targettedUser, query)).equal(true);
353+
should(remoteConfig.processFilter(targetedUser, query)).equal(true);
354354
});
355355

356-
it('Should not match targetted user (combination query)', () => {
357-
const targettedUser = {
356+
it('Should not match targeted user (combination query)', () => {
357+
const targetedUser = {
358358
_id: '1c5c91e1dd594d457a656fad1e55d0cf2a3f0601',
359359
uid: '13',
360-
did: 'targetted_user',
360+
did: 'targeted_user',
361361
cc: 'UK',
362362
av: '1:0:0',
363363
chr: {
@@ -370,11 +370,11 @@ describe('Fetch remote config', () => {
370370
const query = {
371371
$or: [
372372
{ 'up.cc': { $nin: ['UK'] }, chr: { $nin: ['chr_id'] } },
373-
{ did: { $nin: ['targetted_user'] }, 'up.av': { $gt: '2:0:0' } },
373+
{ did: { $nin: ['targeted_user'] }, 'up.av': { $gt: '2:0:0' } },
374374
],
375375
};
376376

377-
should(remoteConfig.processFilter(targettedUser, query)).equal(false);
377+
should(remoteConfig.processFilter(targetedUser, query)).equal(false);
378378
});
379379

380380
it('Should fetch remote config with default value', async() => {
@@ -399,7 +399,7 @@ describe('Fetch remote config', () => {
399399
api_key: API_KEY_ADMIN,
400400
app_id: APP_ID,
401401
app_key: APP_KEY,
402-
device_id: TARGETTED_USER_ID,
402+
device_id: TARGETED_USER_ID,
403403
method: 'fetch_remote_config',
404404
})
405405
.expect(200);

0 commit comments

Comments
 (0)