Skip to content

Commit a7edaf3

Browse files
feat: change impl to only change non-defaults reset
1 parent afb8133 commit a7edaf3

File tree

1 file changed

+32
-6
lines changed

1 file changed

+32
-6
lines changed

plugins/sdk/frontend/public/javascripts/countly.views.js

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -337,14 +337,40 @@
337337

338338
var params = self.$store.getters["countlySDK/sdk/all"];
339339
var data = params || {};
340+
340341
for (var key in self.configs) {
341-
self.configs[key].value = self.configs[key].default;
342-
data[key] = self.configs[key].value;
342+
var current = self.configs[key].value;
343+
var def = self.configs[key].default;
344+
345+
// Reset only if not already default
346+
if (current !== def) {
347+
self.configs[key].value = def;
348+
349+
if (self.diff.indexOf(key) === -1) {
350+
self.diff.push(key);
351+
}
352+
353+
// Clean up diff if value matches SDK or default
354+
if (typeof data[key] !== "undefined") {
355+
if (data[key] === def) {
356+
self.diff.splice(
357+
self.diff.indexOf(key),
358+
1
359+
);
360+
}
361+
}
362+
else if (def === self.configs[key].default) {
363+
self.diff.splice(self.diff.indexOf(key), 1);
364+
}
365+
}
343366
}
344-
self.$store.dispatch("countlySDK/sdk/update", data).then(function() {
345-
self.$store.dispatch("countlySDK/initialize");
346-
});
347-
}, ["No, don't reset", "Yes, reset"], {title: helper_title});
367+
if (self.diff.length !== 0) {
368+
self.save();
369+
}
370+
},
371+
["No, don't reset", "Yes, reset"],
372+
{ title: helper_title }
373+
);
348374
},
349375
save: function() {
350376
var params = this.$store.getters["countlySDK/sdk/all"];

0 commit comments

Comments
 (0)