Skip to content

Commit ef6362c

Browse files
Merge remote-tracking branch 'origin/master' into fix-allow-changing-datatable-per-row
2 parents f223bb1 + f611bee commit ef6362c

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1-
## Version 25.03.xx
1+
## Version 25.03.XX
2+
Fixes:
3+
- [push] Fixed the options of the request being made during mime detection
4+
25
Enterprise Fixes:
6+
- [concurrent_users] Fix alert threshold comparison
37
- [surveys] Handle multiple survey submission from same user based on survey visibility
48
- [users] Set correct users widget table rows amount according to selected setting
59

plugins/alerts/frontend/public/javascripts/countly.models.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@
569569
compareValue: list[j].users,
570570
compareValue2: list[j].minutes,
571571
alertValues: list[j].email,
572-
createdByUser: "-",
572+
createdByUser: list[j].createdByUser || '-',
573573
_canUpdate: countlyAuth.validateUpdate(
574574
FEATURE_NAME,
575575
countlyGlobal.member,

plugins/push/api/proxy.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,6 @@ function request(url, method, conf) {
147147
let opts = {}, proto;
148148
try {
149149
let u = new URL(url);
150-
opts.host = u.hostname;
151-
opts.port = u.port;
152-
opts.path = u.pathname;
153-
opts.protocol = u.protocol;
154150
proto = u.protocol.substring(0, u.protocol.length - 1);
155151
if (!protos[proto]) {
156152
return new Error('Invalid protocol in url ' + url);
@@ -161,7 +157,7 @@ function request(url, method, conf) {
161157
}
162158
catch (e) {
163159
log.e('Failed to parse media URL', e);
164-
opts = {method, url};
160+
opts = {method};
165161
proto = url.substr(0, url.indexOf(':'));
166162
}
167163

@@ -175,9 +171,7 @@ function request(url, method, conf) {
175171
});
176172
opts.agent = new Agent();
177173
}
178-
179-
opts.url = url;
180-
return protos[proto].request(opts);
174+
return protos[proto].request(url, opts);
181175
}
182176

183177

0 commit comments

Comments
 (0)