Merge branch 'master' into ar2rsawseen/master2

Author: ar2rsawseen

.github/workflows/main.yml

@@ -278,6 +278,13 @@ jobs:
           wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -O /tmp/chrome.deb
           apt install -y /tmp/chrome.deb
 
+      - name: Install Sharp dependencies for image processing
+        shell: bash
+        run: |
+          export DEBIAN_FRONTEND=noninteractive
+          apt-get update -y
+          apt-get install -y libvips-dev
+
       - name: Copy code
         shell: bash
         run: cp -rf ./* /opt/countly
@@ -331,6 +338,6 @@ jobs:
         working-directory: /opt/countly/ui-tests/cypress
         run: |
           ARTIFACT_ARCHIVE_NAME="$(date '+%Y%m%d-%H.%M')_${GITHUB_REPOSITORY#*/}_CI#${{ github.run_number }}_${{ matrix.test_type }}.tar.gz"
-          mkdir -p screenshots videos
-          tar zcvf "$ARTIFACT_ARCHIVE_NAME" screenshots videos
+          mkdir -p screenshots videos downloads
+          tar zcvf "$ARTIFACT_ARCHIVE_NAME" screenshots videos downloads
           curl -o /tmp/uploader.log -u "${{ secrets.BOX_UPLOAD_AUTH }}" ${{ secrets.BOX_UPLOAD_PATH }} -T "$ARTIFACT_ARCHIVE_NAME"

CHANGELOG.md

@@ -1,8 +1,40 @@
-## Version 25.03.xx
+## Version 25.03.28
+Fixes:
+- [alerts] Add alert interval validation in the frontend
+- [events] Correctly navigate to event groupmin events menu
+
+Enterprise Fixes:
+- [applications] Ensure application management list reorders after create/update
+- [concurrent_users] Fix email check for alert
+- [dashboards] Keep dashboard sidebar sorted alphabetically after additions
+- [data-manager] Correctly show last triggered for events if data masking is enabled
+
+## Version 25.03.27
+Fixes:
+- [core-vis] Fix chart legend click event
+- [push] Fixed the options of the request being made during mime detection
+- [views] Fix view name that is displayed in view table
+- [data-manager] Fix last modified data for event and segment
+
+Enterprise Fixes:
+- [concurrent_users] Fix alert threshold comparison
+- [dashboards] Add setting to disable public dashboards
+- [surveys] Handle multiple survey submission from same user based on survey visibility
+- [users] Display user property limits in user profiles when exceeded
+- [users] Set correct users widget table rows amount according to selected setting
+
+## Version 25.03.26
 Fixes:
 - [push] Fixed timeout setting
 - [security] Fixed injection possibility on res.expose
 
+Enterprise Fixes:
+- [data-manager] Fixed bug when merging events with ampersand symbol in the name
+- [groups] Add logs for user updates
+- [nps] Sort widgets by internal name and search by name or internal name
+- [surveys] Change question map log to debug log
+- [surveys] Sort widgets by internal name and search by name or internal name
+
 Dependencies:
 - Bump axios from 1.12.2 to 1.13.1 in /plugins/cognito
 - Bump csvtojson from 1.1.12 to 2.0.14
@@ -23,7 +55,7 @@ Fixes:
 Enterprise Fixes:
 - [ab-testing] Add script for fixing variant cohort
 - [groups] Fix user permission update after updating user group permission
-
+- [funnels] Fixed delete confirmation using correct button copy
 
 ## Version 25.03.24
 Fixes:

api/parts/data/fetch.js

@@ -137,6 +137,8 @@ fetch.fetchEventGroups = function(params) {
 fetch.fetchMergedEventGroups = function(params) {
     const { qstring: { event } } = params;
     fetch.getMergedEventGroups(params, event, {}, function(result) {
+        result = result || {};
+        result.eventName = params.qstring.event;
         common.returnOutput(params, result);
     });
 };

bin/scripts/export-data/setting_limits_and_real_values.js

@@ -19,8 +19,8 @@ const DEFAULT_LIMITS = {
     view_name_limit: 128,
     view_segment_limit: 100,
     view_segment_value_limit: 10,
-    //custom_prop_limit: 20,
-    custom_property_limit: 20,
+    custom_prop_limit: 20,
+    //custom_property_limit: 20,
     custom_prop_value_limit: 50,
 };
 Promise.all([pluginManager.dbConnection("countly"), pluginManager.dbConnection("countly_drill")]).then(async function([countlyDb, drillDb]) {
@@ -56,8 +56,8 @@ Promise.all([pluginManager.dbConnection("countly"), pluginManager.dbConnection("
                         view_name_limit: pluginsCollectionPlugins?.views?.view_name_limit || DEFAULT_LIMITS.view_name_limit,
                         view_segment_limit: pluginsCollectionPlugins?.views?.segment_limit || DEFAULT_LIMITS.view_segment_limit,
                         view_segment_value_limit: pluginsCollectionPlugins?.views?.segment_value_limit || DEFAULT_LIMITS.view_segment_value_limit,
-                        //custom_prop_limit: pluginsCollectionPlugins?.users?.custom_prop_limit || DEFAULT_LIMITS.custom_prop_limit,
-                        custom_property_limit: pluginsCollectionPlugins?.drill?.custom_property_limit || DEFAULT_LIMITS.custom_property_limit,
+                        custom_prop_limit: pluginsCollectionPlugins?.users?.custom_prop_limit || DEFAULT_LIMITS.custom_prop_limit,
+                        //custom_property_limit: pluginsCollectionPlugins?.drill?.custom_property_limit || DEFAULT_LIMITS.custom_property_limit,
                         custom_prop_value_limit: pluginsCollectionPlugins?.users?.custom_set_limit || DEFAULT_LIMITS.custom_prop_value_limit,
                     };
                     // GETTING REAL DATA PER APP
@@ -247,10 +247,10 @@ Promise.all([pluginManager.dbConnection("countly"), pluginManager.dbConnection("
                 });
                 app_results['View Segments Unique Values'] = {"default": defaultVal, "set": currentVal, "real": realVal};
                 // USER PROPERTIES
-                //defaultVal = DEFAULT_LIMITS.custom_prop_limit;
-                //currentVal = CURRENT_LIMITS.custom_prop_limit;
-                defaultVal = DEFAULT_LIMITS.custom_property_limit;
-                currentVal = CURRENT_LIMITS.custom_property_limit;
+                defaultVal = DEFAULT_LIMITS.custom_prop_limit;
+                currentVal = CURRENT_LIMITS.custom_prop_limit;
+                //defaultVal = DEFAULT_LIMITS.custom_property_limit;
+                //currentVal = CURRENT_LIMITS.custom_property_limit;
                 realVal = customPropsPerApp && customPropsPerApp[0]?.customPropertiesCount || 0;
                 app_results['Max user custom properties'] = {"default": defaultVal, "set": currentVal, "real": realVal};
                 // VALUES IN AN ARRAY FOR ONE USER PROPERTY

countly-community

@@ -0,0 +1 @@
+Subproject commit f772bcd2c0e918dcf337ef3d978efbaa986bd882

frontend/express/public/core/app-management/javascripts/countly.views.js

@@ -59,13 +59,12 @@
                     value: id
                 };
             });
-            if (countlyGlobal.member.appSortList) {
-                appList = this.sortBy(appList, countlyGlobal.member.appSortList);
+            var sortList = (countlyGlobal.member && countlyGlobal.member.appSortList) || [];
+            if (sortList.length) {
+                appList = this.sortBy(appList, sortList);
             }
             else {
-                appList.sort(function(a, b) {
-                    return a.label > b.label && 1 || -1;
-                });
+                appList.sort(this.sortAppOptionsAlphabetically);
             }
             var app_id = this.$route.params.app_id || countlyCommon.ACTIVE_APP_ID;
             return {
@@ -340,6 +339,56 @@
                     }
                 }
             },
+            getAppListItemId: function(option) {
+                if (!option) {
+                    return "";
+                }
+
+                return (option._id || option.value || option.id || option.app_id || "") + "";
+            },
+            sortAppOptionsAlphabetically: function(optionA, optionB) {
+                var labelA = (optionA.label || "").toLowerCase();
+                var labelB = (optionB.label || "").toLowerCase();
+
+                if (labelA < labelB) {
+                    return -1;
+                }
+
+                if (labelA > labelB) {
+                    return 1;
+                }
+
+                var valueA = (optionA.value || "").toLowerCase();
+                var valueB = (optionB.value || "").toLowerCase();
+
+                if (valueA < valueB) {
+                    return -1;
+                }
+
+                if (valueA > valueB) {
+                    return 1;
+                }
+
+                return 0;
+            },
+            applyAppListOrdering: function() {
+                if (!Array.isArray(this.appList)) {
+                    return;
+                }
+
+                var sortList = (countlyGlobal.member && countlyGlobal.member.appSortList) || [];
+                var currentList = this.appList.slice();
+                var orderedList;
+
+                if (sortList.length) {
+                    orderedList = this.sortBy(currentList, sortList);
+                }
+                else {
+                    orderedList = currentList.sort(this.sortAppOptionsAlphabetically);
+                }
+
+                this.appList = orderedList;
+            },
             sortBy: function(arrayToSort, sortList) {
                 if (!sortList.length) {
                     return arrayToSort;
@@ -349,9 +398,10 @@
                     retArr = [];
                 var i;
                 for (i = 0; i < arrayToSort.length; i++) {
-                    var objId = arrayToSort[i]._id + "";
-                    if (sortList.indexOf(objId) !== -1) {
-                        tmpArr[sortList.indexOf(objId)] = arrayToSort[i];
+                    var objId = this.getAppListItemId(arrayToSort[i]);
+                    var desiredIndex = sortList.indexOf(objId);
+                    if (desiredIndex !== -1) {
+                        tmpArr[desiredIndex] = arrayToSort[i];
                     }
                 }
 
@@ -392,6 +442,7 @@
                                     value: data._id + "",
                                     label: data.name
                                 });
+                                self.applyAppListOrdering();
                                 self.$store.dispatch("countlyCommon/addToAllApps", data);
                                 self.$store.dispatch("countlyCommon/updateActiveApp", data._id + "");
                                 countlyCommon.setActiveApp(data._id);
@@ -459,6 +510,7 @@
                                 break;
                             }
                         }
+                        self.applyAppListOrdering();
                         self.discardForm();
                         CountlyHelpers.notify({
                             title: jQuery.i18n.map["configs.changed"],

frontend/express/public/core/events/javascripts/countly.details.models.js

@@ -902,7 +902,13 @@
                                 res.list = res.list.map(eventName => countlyCommon.unescapeHtml(eventName));
                             }
                             context.commit("setAllEventsData", res);
-                            if ((!context.state.selectedEventName) || (res.map && res.map[context.state.selectedEventName] && !res.map[context.state.selectedEventName].is_visible) || (res.list && res.list.indexOf(context.state.selectedEventName) === -1)) {
+                            var is_group = false;
+                            if (context.state.selectedEventName && context.state.selectedEventName.startsWith('[CLY]_group')) {
+                                is_group = true;
+                            }
+                            if ((!context.state.selectedEventName) ||
+                            (res.map && res.map[context.state.selectedEventName] && !res.map[context.state.selectedEventName].is_visible) ||
+                            (res.list && res.list.indexOf(context.state.selectedEventName) === -1 && context.state && !is_group)) {
                                 var appId = countlyCommon.ACTIVE_APP_ID;
                                 var eventKeyForStorage = {};
                                 var eventKey = res.list[0];