Regex fix for edge cases #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion:
($user, $cpu, $memory, $command) = $l =~ m{^(\w+)\s+\d+\s+(\d{1,2}\.\d)\s+(\d{1,2}\.\d).*\d{1,2}:\d{2}\s+(.*)$};
Problems:
(\w+) only matches word characters, but user:20 in ps pads usernames with spaces.
The %CPU field could be >99, so (\d{1,2}\.\d) will not match '100' or higher. It expects a decimal like 2.3.
The ps output for %CPU is integer (not decimal) for large values.
The line starts with the process name, plus spaces.
Fixed with:
$l =~ s/^\s+//; # remove leading spaces
my @fields = split /\s+/, $l, 11;
my ($user, $pid, $cpu, $memory, $vsz, $rss, $tty, $stat, $start, $time, $command) = @fields;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script tries to match lines with this regex in the read_logs function:
($user, $cpu, $memory, $command) = $l =~ m{^(\w+)\s+\d+\s+(\d{1,2}.\d)\s+(\d{1,2}.\d).\d{1,2}:\d{2}\s+(.)$};
Problems:
(\w+) only matches word characters, but user:20 in ps pads usernames with spaces.
The %CPU field could be >99, so (\d{1,2}.\d) will not match '100' or higher. It expects a decimal like 2.3.
The ps output for %CPU is integer (not decimal) for large values.
The line starts with the process name, plus spaces.
Fixed with:
$l =~ s/^\s+//; # remove leading spaces
my @fields = split /\s+/, $l, 11;
my ($user, $pid, $cpu, $memory, $vsz, $rss, $tty, $stat, $start, $time, $command) = @fields;