Skip to content

Commit d7ab045

Browse files
committed
Merge branch 'master' of github.com:CppCXY/EmmyLuaCodeStyle
2 parents 72c43c0 + 32400e1 commit d7ab045

File tree

2 files changed

+20
-19
lines changed

2 files changed

+20
-19
lines changed

CodeService/src/FormatElement/KeepBlankElement.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ FormatElementType KeepBlankElement::GetType()
1414

1515
void KeepBlankElement::Serialize(FormatContext& ctx, int position, FormatElement& parent)
1616
{
17-
ctx.PrintBlank(_blank);
17+
int nextOffset = getNextValidOffset(position, parent);
18+
if (nextOffset != -1)
19+
{
20+
ctx.PrintBlank(_blank);
21+
}
1822
}
1923

2024
void KeepBlankElement::Diagnosis(DiagnosisContext& ctx, int position, FormatElement& parent)

CodeService/src/LuaFormatter.cpp

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -310,15 +310,6 @@ std::shared_ptr<FormatElement> LuaFormatter::FormatBlock(std::shared_ptr<LuaAstN
310310
case LuaAstNodeType::FunctionStatement:
311311
{
312312
indentEnv->AddChild(FormatNode(statement));
313-
314-
// if (nextMatch(index, LuaAstNodeType::FunctionStatement, statements))
315-
// {
316-
// indentEnv->Add<KeepLineElement>(1);
317-
// }
318-
// else
319-
// {
320-
// indentEnv->Add<MinLineElement>(1);
321-
// }
322313
indentEnv->AddChild(_options.keep_line_after_function_define_statement);
323314
break;
324315
}
@@ -345,14 +336,20 @@ std::shared_ptr<FormatElement> LuaFormatter::FormatLocalStatement(std::shared_pt
345336
case LuaAstNodeType::KeyWord:
346337
case LuaAstNodeType::GeneralOperator:
347338
{
339+
// 基于这样的考虑 可能local 语句没有等号所以nameDefList的空格移上来
340+
if (node->GetText() == "=")
341+
{
342+
env->Add<KeepBlankElement>(1);
343+
}
344+
348345
env->Add<TextElement>(node);
349346
env->Add<KeepBlankElement>(1);
350347
break;
351348
}
352349
case LuaAstNodeType::NameDefList:
353350
{
351+
354352
env->AddChild(FormatNode(node));
355-
env->Add<KeepBlankElement>(1);
356353
break;
357354
}
358355
case LuaAstNodeType::ExpressionList:
@@ -883,12 +880,12 @@ std::shared_ptr<FormatElement> LuaFormatter::FormatIfStatement(std::shared_ptr<L
883880
env->Add<KeepBlankElement>(1);
884881
break;
885882
}
886-
// case LuaAstNodeType::Block:
887-
// {
888-
// env->AddChild(FormatNode(child));
889-
// env->Add<KeepLineElement>();
890-
// break;
891-
// }
883+
// case LuaAstNodeType::Block:
884+
// {
885+
// env->AddChild(FormatNode(child));
886+
// env->Add<KeepLineElement>();
887+
// break;
888+
// }
892889
default:
893890
{
894891
DefaultHandle(child, env);
@@ -908,13 +905,13 @@ std::shared_ptr<FormatElement> LuaFormatter::FormatExpressionStatement(std::shar
908905
{
909906
switch (child->GetType())
910907
{
911-
// 目前表达式语句上只有调用表达式
908+
// 目前表达式语句上只有调用表达式
912909
case LuaAstNodeType::CallExpression:
913910
{
914911
env->AddChild(FormatNode(child));
915912
break;
916913
}
917-
// default 一般只有一个分号
914+
// default 一般只有一个分号
918915
default:
919916
{
920917
DefaultHandle(child, env);

0 commit comments

Comments
 (0)