Rename option "never" to "replace_with_linebreak" for self explainability

Author: AndreaWalchshoferSCCH

CodeFormatCore/include/CodeFormatCore/Config/LuaStyleEnum.h

@@ -87,7 +87,7 @@ enum class AlignChainExpr {
 
 enum class EndStmtWithSemicolon {
     Keep,
-    Never,
+    ReplaceWithLinebreak,
     Always,
     SameLine
 };

CodeFormatCore/src/Config/LuaStyle.cpp

@@ -293,8 +293,8 @@ void LuaStyle::Parse(std::map<std::string, std::string, std::less<>> &configMap)
             end_statement_with_semicolon = EndStmtWithSemicolon::Keep;
         } else if (configMap.at("end_statement_with_semicolon") == "always") {
             end_statement_with_semicolon = EndStmtWithSemicolon::Always;
-        } else if (configMap.at("end_statement_with_semicolon") == "never") {
-            end_statement_with_semicolon = EndStmtWithSemicolon::Never;
+        } else if (configMap.at("end_statement_with_semicolon") == "replace_with_linebreak") {
+            end_statement_with_semicolon = EndStmtWithSemicolon::ReplaceWithLinebreak;
         } else if (configMap.at("end_statement_with_semicolon") == "same_line") {
             end_statement_with_semicolon = EndStmtWithSemicolon::SameLine;
         }

CodeFormatCore/src/Diagnostic/CodeStyle/CodeStyleChecker.cpp

@@ -96,7 +96,7 @@ void CodeStyleChecker::BasicResolve(LuaSyntaxNode syntaxNode, const LuaSyntaxTre
             }
             case TokenStrategy::StmtEndSemicolon: {
                 switch (d.GetState().GetStyle().end_statement_with_semicolon) {
-                    case EndStmtWithSemicolon::Never: {
+                    case EndStmtWithSemicolon::ReplaceWithLinebreak: {
                         d.PushDiagnostic(DiagnosticType::Semicolon, textRange,
                                          LText("expected statement not to end with ;"));
                         break;

CodeFormatCore/src/Format/Analyzer/SemicolonAnalyzer.cpp

@@ -25,7 +25,7 @@ void SemicolonAnalyzer::Analyze(FormatState &f, const LuaSyntaxTree &t) {
                         }
                         break;
                     }
-                    case EndStmtWithSemicolon::Never: {
+                    case EndStmtWithSemicolon::ReplaceWithLinebreak: {
                         // no action needed when there's no semicolons at all!
                         if (ContainsSemicolon(syntaxNode, t)) {
                             if (EndsWithSemicolon(syntaxNode, t)) {

Test/src/FormatStyle_unitest.cpp

@@ -1621,7 +1621,7 @@ local table1 = { 1, 2, 3 };
 )",
             style));
 
-    style.end_statement_with_semicolon = EndStmtWithSemicolon::Never;
+    style.end_statement_with_semicolon = EndStmtWithSemicolon::ReplaceWithLinebreak;
     EXPECT_TRUE(TestHelper::TestFormatted(
             R"(
 local func = testFunc; print(type(nil)); -- nil;