fix credentials tests

Author: magnurud

src/cradl/credentials.py

@@ -145,7 +145,7 @@ def read_from_file(credentials_path: str = expanduser('~/.cradl/credentials.json
     client_secret = credentials.get('client_secret')
     auth_endpoint = credentials.get('auth_endpoint')
     api_endpoint = credentials.get('api_endpoint')
-    cached_profile = profile if credentials.get('use_cache', fallback=False) in ['true', 'True'] else None
+    cached_profile = profile if credentials.get('use_cache', False) else None
 
     return [client_id, client_secret, auth_endpoint, api_endpoint, cached_profile]
 

tests/test_credentials.py

@@ -18,18 +18,25 @@
 def section():
     return 'test'
 
+@pytest.fixture
+def use_cache():
+    return None
+
 
 @pytest.fixture
-def credentials_path(tmp_path, section):
+def credentials_path(tmp_path, section, use_cache):
     credentials_path = tmp_path / 'credentials.json'
-    credentials_path.write_text(json.dumps({
+    credentials_dict = {
         section: {
             'client_id': 'test',
             'auth_endpoint': 'test',
             'api_endpoint': 'test',
             'client_secret': 'test',
         }
-    }))
+    }
+    if isinstance(use_cache, bool):
+        credentials_dict[section]['use_cache'] = use_cache
+    credentials_path.write_text(json.dumps(credentials_dict, indent=2))
     return credentials_path
 
 
@@ -97,20 +104,17 @@ def test_credentials_with_cache(cache_path, token, section):
     assert credentials._token == (token['access_token'], token['expires_in'])
     assert credentials.cached_profile == section
 
-
+@pytest.mark.parametrize('use_cache', [True])
 def test_read_from_file_with_cache(credentials_path, section, token, cache_path):
     write_token_to_cache(section, (token['access_token'], token['expires_in']), cache_path)
-    credentials_path.write_text(credentials_path.read_text() + '\nuse_cache = true')
     args = read_from_file(str(credentials_path), section)
-
     credentials = Credentials(*args, cache_path=cache_path)
     assert credentials.cached_profile == section
     assert credentials._token == (token['access_token'], token['expires_in'])
 
-
+@pytest.mark.parametrize('use_cache', [False])
 def test_read_from_file_with_no_cache(credentials_path, section, token, cache_path):
     write_token_to_cache(section, (token['access_token'], token['expires_in']), cache_path)
-    credentials_path.write_text(credentials_path.read_text() + '\nuse_cache = false')
     args = read_from_file(str(credentials_path), section)
 
     credentials = Credentials(*args, cache_path=cache_path)