Remove unused arguments (#145)

* Remove in and out schemas from transitions

* update version

Author: magnurud

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 11.4.1 - 2024-12-02
+
+- Remove `in_schema` and `out_schema` from `create_transition` and `update_transition`
+
 ## Version 11.4.0 - 2024-11-21
 
 - Added `get_prediction`

las/__version__.py

@@ -7,4 +7,4 @@
 __maintainer_email__ ='magnus@lucidtech.ai'
 __title__ = 'lucidtech-las'
 __url__ = 'https://github.com/LucidtechAI/las-sdk-python'
-__version__ = '11.4.0'
+__version__ = '11.4.1'

las/client.py

@@ -1844,8 +1844,6 @@ def create_transition(
         self,
         transition_type: str,
         *,
-        in_schema: Optional[dict] = None,
-        out_schema: Optional[dict] = None,
         parameters: Optional[dict] = None,
         **optional_args,
     ) -> Dict:
@@ -1855,25 +1853,19 @@ def create_transition(
         >>> from pathlib import Path
         >>> from las.client import Client
         >>> client = Client()
-        >>> in_schema = {'$schema': 'https://json-schema.org/draft-04/schema#', 'title': 'in', 'properties': {...} }
-        >>> out_schema = {'$schema': 'https://json-schema.org/draft-04/schema#', 'title': 'out', 'properties': {...} }
         >>> # A typical docker transition
         >>> docker_params = {
         >>>     'imageUrl': '<image_url>',
         >>>     'credentials': {'username': '<username>', 'password': '<password>'}
         >>> }
-        >>> client.create_transition('docker', in_schema=in_schema, out_schema=out_schema, params=docker_params)
+        >>> client.create_transition('docker', params=docker_params)
         >>> # A manual transition with UI
         >>> assets = {'jsRemoteComponent': 'las:asset:<hex-uuid>', '<other asset name>': 'las:asset:<hex-uuid>'}
         >>> manual_params = {'assets': assets}
-        >>> client.create_transition('manual', in_schema=in_schema, out_schema=out_schema, params=manual_params)
+        >>> client.create_transition('manual', params=manual_params)
 
         :param transition_type: Type of transition "docker"|"manual"
         :type transition_type: str
-        :param in_schema: Json-schema that defines the input to the transition
-        :type in_schema: dict, optional
-        :param out_schema: Json-schema that defines the output of the transition
-        :type out_schema: dict, optional
         :param name: Name of the transition
         :type name: str, optional
         :param parameters: Parameters to the corresponding transition type
@@ -1887,8 +1879,6 @@ def create_transition(
  :py:class:`~las.LimitExceededException`, :py:class:`requests.exception.RequestException`
         """
         body = dictstrip({
-            'inputJsonSchema': in_schema,
-            'outputJsonSchema': out_schema,
             'transitionType': transition_type,
             'parameters': parameters,
         })
@@ -1949,8 +1939,6 @@ def update_transition(
         self,
         transition_id: str,
         *,
-        in_schema: Optional[dict] = None,
-        out_schema: Optional[dict] = None,
         assets: Optional[dict] = None,
         cpu: Optional[int] = None,
         memory: Optional[int] = None,
@@ -1971,10 +1959,6 @@ def update_transition(
         :type name: str, optional
         :param description: Description of the transition
         :type description: str, optional
-        :param in_schema: Json-schema that defines the input to the transition
-        :type in_schema: dict, optional
-        :param out_schema: Json-schema that defines the output of the transition
-        :type out_schema: dict, optional
         :param assets: A dictionary where the values are assetIds that can be used in a manual transition
         :type assets: dict, optional
         :param environment: Environment variables to use for a docker transition
@@ -1996,11 +1980,7 @@ def update_transition(
         :raises: :py:class:`~las.InvalidCredentialsException`, :py:class:`~las.TooManyRequestsException`,\
  :py:class:`~las.LimitExceededException`, :py:class:`requests.exception.RequestException`
         """
-        body = dictstrip({
-            'inputJsonSchema': in_schema,
-            'outputJsonSchema': out_schema,
-        })
-
+        body = {}
         parameters = dictstrip({
             'assets': assets,
             'cpu': cpu,

tests/test_transitions.py

@@ -17,11 +17,8 @@
 ])
 @pytest.mark.parametrize('name_and_description', util.name_and_description_combinations())
 def test_create_transition(client: Client, transition_type, parameters, name_and_description):
-    schema = util.create_json_schema()
     response = client.create_transition(
         transition_type,
-        in_schema=schema,
-        out_schema=schema,
         parameters=parameters,
         **name_and_description,
     )
@@ -73,25 +70,9 @@ def test_get_transition_execution(client: Client):
     assert 'status' in response, 'Missing status in response'
 
 
-@pytest.mark.parametrize(('in_schema', 'out_schema'), [
-    (None, None),
-    ({'foo': 'bar'}, None),
-    (None, {'foo': 'bar'}),
-    ({'foo': 'bar'}, {'foo': 'bar'}),
-])
 @pytest.mark.parametrize('name_and_description', util.name_and_description_combinations(True))
-def test_update_transition(
-    client: Client,
-    name_and_description,
-    in_schema,
-    out_schema,
-):
-    response = client.update_transition(
-        service.create_transition_id(),
-        in_schema=in_schema,
-        out_schema=out_schema,
-        **name_and_description,
-    )
+def test_update_transition(client: Client, name_and_description):
+    response = client.update_transition(service.create_transition_id(), **name_and_description)
     logging.info(response)
     assert_transition(response)
 
@@ -119,8 +100,8 @@ def test_update_transition_parameters_manual(client: Client, assets):
     (None, None),
 ])
 def test_update_transition_parameters_docker(
-    client: Client, 
-    environment, 
+    client: Client,
+    environment,
     environment_secrets,
     cpu,
     memory,