Fixing warnings

Author: einari

Integration/DotNET.InProcess/for_EventSequence/when_appending_event_with_registered_migration/ContractSigned.cs

@@ -7,7 +7,7 @@ namespace Cratis.Chronicle.InProcess.Integration.for_EventSequence.when_appendin
 
 /// <summary>
 /// Generation 1 of <see cref="ContractSigned"/>. Has only a contract identifier.
-/// Generation 2 adds a <see cref="Status"/> property, defaulting to <c>pending</c> for events
+/// Generation 2 adds a <c>Status</c> property, defaulting to <c>pending</c> for events
 /// stored before the property existed.
 /// </summary>
 /// <param name="ContractId">The contract identifier.</param>

Integration/DotNET.InProcess/for_EventSequence/when_appending_event_with_registered_migration/ContractSignedMigrator.cs

@@ -21,10 +21,7 @@ public class ContractSignedMigrator : IEventTypeMigrationFor<ContractSigned>
 
     /// <inheritdoc/>
     public void Upcast(IEventMigrationBuilder builder) =>
-        builder.Properties(pb =>
-        {
-            pb.DefaultValue("status", "pending");
-        });
+        builder.Properties(pb => pb.DefaultValue("status", "pending"));
 
     /// <inheritdoc/>
     public void Downcast(IEventMigrationBuilder builder)

Source/Clients/DotNET.Specs/Events/for_EventTypes/when_registering/and_event_type_has_complete_migration_chain.cs

@@ -6,11 +6,11 @@
 
 namespace Cratis.Chronicle.Events.for_EventTypes.when_registering;
 
-[EventType(generation: 2)]
-file record Gen2TestEventWithValidChain(string Name);
-
 public class and_event_type_has_complete_migration_chain : given.all_dependencies
 {
+    [EventType(generation: 2)]
+    record Gen2TestEventWithValidChain(string Name);
+
     EventTypes _subject;
 
     void Establish()

Source/Clients/DotNET.Specs/Events/for_EventTypes/when_registering/and_event_type_is_generation_1.cs

@@ -5,11 +5,11 @@
 
 namespace Cratis.Chronicle.Events.for_EventTypes.when_registering;
 
-[EventType]
-file record Gen1TestEvent(string Name);
-
 public class and_event_type_is_generation_1 : given.all_dependencies
 {
+    [EventType]
+    record Gen1TestEvent(string Name);
+
     EventTypes _subject;
 
     void Establish()

Source/Kernel/Core/Services/EventTypes/EventTypes.cs

@@ -27,7 +27,7 @@ public async Task Register(RegisterEventTypesRequest request)
 #if DEVELOPMENT
         var skipValidation = request.DisableValidation;
 #else
-        var skipValidation = false;
+        const bool skipValidation = false;
 #endif
         if (!skipValidation)
         {